Conversation
I updated to newest version of JSignPdf and also of jre Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
|
@vitormattos Two points:
|
|
@vitormattos Another point: can we download the JRE at download runtime? I'm not sure if that's possible, but maybe we could remove the JRE from our package and download it at download runtime from an external repository, such as: https://github.com/adoptium/temurin21-binaries/releases |
|
I used the JRE, but the package internally uses files with "JDK" in their names. In LibreSign, is downloaded a specific JRE and JSignPdf version and set the path of both. P.S.: In LibreSign, I don't use this package. We could implement something similar by locking the dependencies to a specific Java and JSignPdf version. I'll think more about this... If we move in that direction, we might not need this repository anymore. |
|
@jeidison what do you think about setting the URL of files to download and fix the compress engine as .tar.gz that is used by adoptium/temurin21 ? We can do this at the other package side. I can send a PR with this POC. |
|
@jeidison look here the purpose to solve this and remove the dependency of this repository: |
|
@jeidison I think that now we can archive this repository. |
Yes, we can! |
to-do