Skip to content

ci: run the contract api-schemas drift check in CI, not only in the local gate #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 2 commits into from
+18 −0
Closed

ci: run the contract api-schemas drift check in CI, not only in the local gate #10268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bb5a9a
ci: run the contract api-schemas drift check in CI, not only in the l…
JSONbored Jul 31, 2026
1db8968
Merge branch 'main' into claude/wire-contract-api-schemas-ci
JSONbored Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
mcp: ${{ steps.filter.outputs.mcp }}
mcpCliHarness: ${{ steps.filter.outputs.mcpCliHarness }}
engine: ${{ steps.filter.outputs.engine }}
contract: ${{ steps.filter.outputs.contract }}
discoveryIndex: ${{ steps.filter.outputs.discoveryIndex }}
miner: ${{ steps.filter.outputs.miner }}
minerTestHarness: ${{ steps.filter.outputs.minerTestHarness }}
Expand Down Expand Up @@ -188,6 +189,10 @@ jobs:
engine:
- 'packages/loopover-engine/**'
- 'package-lock.json'
contract:
- 'packages/loopover-contract/**'
- 'scripts/gen-contract-api-schemas.ts'
- 'package-lock.json'
miner:
- 'packages/loopover-miner/**'
- 'scripts/check-miner-package.ts'
Expand Down Expand Up @@ -822,6 +827,19 @@ jobs:
- name: OpenAPI drift check
if: ${{ github.event_name == 'push' || needs.changes.outputs.ui == 'true' || needs.changes.outputs.uiContract == 'true' }}
run: npm run ui:openapi:check
# Same generated-artifact-drift class as the OpenAPI check above, and it was enforced ONLY by the
# local `npm run test:ci` aggregate -- exactly the local-only gap called out on the selfhost/miner
# env-reference steps in validate-code, which each went stale with zero CI signal until someone
# happened to run the full local script. It has now bitten this file twice (#10237): once when the
# discovery-route schemas were added without teaching the generator, leaving `main` red for every PR
# that ran the local gate, and again when #10160 added `linkedIssueMaintainerExempt` without
# regenerating. Neither surfaced in CI.
# Its inputs are src/openapi/schemas.ts (`backend`), apps/loopover-ui/public/openapi.json (`ui`), and
# the contract package's own modules, which it scans to emit imports -- hence the third filter, added
# with this step because nothing here previously watched packages/loopover-contract/** at all.
- name: Contract api-schemas drift check
if: ${{ github.event_name == 'push' || needs.changes.outputs.backend == 'true' || needs.changes.outputs.ui == 'true' || needs.changes.outputs.contract == 'true' }}
run: npm run contract:api-schemas:check
# Checks apps/loopover-ui/src' known-latest MCP version string against the published package, so
# its dependency is `ui` (the file it scans) + `mcp` (the package it checks against) -- NOT the
# OpenAPI contract, which this script never reads.
Expand Down