Open
Conversation
These functions will be added to data_processing.R once approved. The scripts are modifications of @epbrenner 's hmmering and rhmmer.
Removed redundant line reading from file as it was already handled earlier in the code.
jananiravi
approved these changes
Apr 3, 2026
Member
jananiravi
left a comment
jananiravi
left a comment
There was a problem hiding this comment.
It looks like you moved a line -- unless I'm missing something, it's good to merge!
jananiravi
reviewed
Apr 3, 2026
Member
jananiravi
left a comment
jananiravi
left a comment
There was a problem hiding this comment.
I see that I commented on one commit earlier -- sorry about that!
In principle, it looks good. I would like to request @eboyer221 or @epbrenner to run this locally and suggest non-alpine placeholders to ensure this works for all!
| combined_drug_data <- unlist(batch_drug_data, use.names = FALSE) | ||
| if (length(combined_drug_data) == 0) { message("No drug data returned."); return(NULL) } | ||
| if (length(combined_drug_data) == 0) { | ||
| message("No drug data returned.") |
| combined_genome_data <- unlist(batch_genome_data, use.names = FALSE) | ||
| if (length(combined_genome_data) == 0) { message("No genome data returned."); return(NULL) } | ||
| if (length(combined_genome_data) == 0) { | ||
| message("No genome data returned.") |
Member
There was a problem hiding this comment.
found/returned/retrieved? same Q as before.
| chunk_size <- ceiling(length(records) / chunk_count) | ||
| chunks <- split(records, ceiling(seq_along(records) / chunk_size)) | ||
|
|
||
| purrr::walk2(chunks, seq_along(chunks), function(chunk, i) { |
Member
There was a problem hiding this comment.
| "exec", | ||
| "-B", paste0(mount_host, ":", mount_cont), | ||
| "-B", paste0(db_host_dir, ":", db_cont_dir), | ||
| "/scratch/alpine/aghosh5@xsede.org/software/hmmer_latest.sif", |
|
|
||
| message("Combined parquet written") | ||
|
|
||
| # arrow::read_parquet("/scratch/alpine/aghosh5@xsede.org/AMR/data/Campylobacter_jejuni/protein_COG_count.parquet") |> DBI::dbWriteTable(conn=con, name="protein_COG_count") |
Member
There was a problem hiding this comment.
hardcoded path alert. cannot be part of the public amRdata repo.
| cdhit_extra_args = c("-g", "1"), | ||
| cdhit_output_prefix = "cdhit_out", | ||
| # InterPro | ||
| ipr_appl = c("Pfam"), |
Member
There was a problem hiding this comment.
user can switch: Pfam vs. something else? @AbhirupaGhosh @epbrenner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions will be added to data_processing.R once approved.
The scripts are modifications of @epbrenner 's hmmering and rhmmer.
Description
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.