Icon deb

[jamesmarkchan]

ubuntu deb support for turtle icon on task bar, app window, about box already present.

[Copilot]

Pull request overview

Adds Ubuntu/Debian packaging and Swing UI updates so the JDiskMark “turtle” branding icon is used more consistently (installer/package icon + app window/taskbar + About dialog).

Changes:

• DEB (jpackage) packaging: add --icon and custom --resource-dir with .desktop + postinst templates.
• DEB-slim (jdeb) packaging: install a pixmap icon and a desktop entry with Icon= and StartupWMClass=.
• Core UI: load a shared branding icon from classpath resources and apply it to the main window and About dialog.

Reviewed changes

Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
jdm-dist/jdm-deb/src/main/jpackage-resources/template.postinst	Adds post-install template used by jpackage DEB builds.
jdm-dist/jdm-deb/src/main/jpackage-resources/template.desktop	Adds desktop-entry template for jpackage DEB builds (includes icon/taskbar metadata).
jdm-dist/jdm-deb/pom.xml	Adds jpackage icon/resource-dir and a verify-time DEB desktop patch/repack step.
jdm-dist/jdm-deb-slim/src/deb/share/jdiskmark.desktop	Adds a desktop entry for the slim DEB package.
jdm-dist/jdm-deb-slim/pom.xml	Installs the icon into /usr/share/pixmaps and the desktop entry into /usr/share/applications.
jdm-core/src/main/java/jdiskmark/MainFrame.java	Adds icon to the About dialog.
jdm-core/src/main/java/jdiskmark/Gui.java	Sets the window icon image for titlebar/taskbar.
jdm-core/src/main/java/jdiskmark/App.java	Introduces AppIcon enum and resource-based icon loading.

Comments suppressed due to low confidence (1)

jdm-dist/jdm-deb/pom.xml:86

• This sed replacement injects GenericName, Keywords, and StartupWMClass at the Categories= line, but template.desktop already contains GenericName, Keywords, and StartupWMClass. As a result, the repacked desktop entry will contain duplicate keys (and potentially conflicting StartupWMClass values), which can cause desktop environment parsing/icon matching to behave unpredictably. Either remove this patching step or stop emitting those fields in the template so each key appears exactly once.

if [ -n "$DESKTOP" ]; then
    sed -i 's|^Name=jdiskmark$|Name=JDiskMark|' "$DESKTOP"
    sed -i 's|^Categories=\(.*\)|GenericName=Disk Benchmark\nCategories=\1\nKeywords=disk;benchmark;performance;storage;speed;\nStartupWMClass=jdiskmark-App|' "$DESKTOP"
    echo "[patch] Result ($(basename $DESKTOP)):"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jamesmarkchan]

current icon size in about is smaller