Skip to content

Comments

update bacio, crtm module vars in common/modules_*.yaml#1925

Merged
climbfuji merged 5 commits intoJCSDA:developfrom
AlexanderRichert-NOAA:bacio_crtm_modulevars_feb26
Feb 19, 2026
Merged

update bacio, crtm module vars in common/modules_*.yaml#1925
climbfuji merged 5 commits intoJCSDA:developfrom
AlexanderRichert-NOAA:bacio_crtm_modulevars_feb26

Conversation

@AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Feb 18, 2026

Description

This PR updates the bacio vars to use $BACIO_LIB and $BACIO_INC instead of being suffixed with 4/8, reflecting the removal of the type-differentiated library versions following bacio 2.6.0. It also changes $CRTM_LIB to point to the shared library.

Dependencies

none

Issues addressed

Fixes #1894

Applications affected

most applications are affected

Systems affected

all

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • Additional testing: Add information on any additional tests conducted
    • test on Acorn: install crtm 3.1.3 and bacio 2.6.0 with module files and verify that BACIO_LIB/BACIO_INC/CRTM_LIB point to existing paths.

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@AlexanderRichert-NOAA
Copy link
Collaborator Author

@RussTreadon-NOAA @DavidHuber-NOAA please let me know if the paths here make sense based on what you need. I'll also test on at least one system to make sure the paths line up.
Ideally downstream applications would find and configure these dependencies via CMake/CMAKE_PREFIX_PATH. Also we may wish to consider incorporating these into the various package.py's to avoid system-specific differences in lib vs. lib64 etc.

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review February 18, 2026 19:04
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look reasonable to me. I'm happy to see fewer _4 and _8's in the paths.

@climbfuji
Copy link
Collaborator

I'll merge this after #1924

@climbfuji climbfuji merged commit 9da3419 into JCSDA:develop Feb 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ursa spack-stack/2.0.0 bacio/2.6.0 INC and LIB variables point at non-existent paths

3 participants