[SDK-483] 0.85.2#867
Conversation
|
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
There was a problem hiding this comment.
Pull request overview
This PR upgrades the repo (library + example app) React Native toolchain to React Native 0.85.2 and updates related build/test configuration to match that version.
Changes:
- Bump
react-nativeand associated@react-native/*packages to0.85.2(including lockfile updates). - Switch Jest configuration to use
@react-native/jest-preset. - Update example app native project files (iOS CocoaPods integration + Android Gradle wrapper version).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates dependency graph/lock entries for RN 0.85.2 and related tooling. |
| package.json | Bumps RN-related devDependencies to 0.85.2 and adds @react-native/jest-preset. |
| jest.config.js | Switches Jest preset to @react-native/jest-preset. |
| example/package.json | Bumps example app RN + related @react-native/* devDependencies to 0.85.2. |
| example/jest.config.js | Switches example Jest preset to @react-native/jest-preset. |
| example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj | Updates CocoaPods-generated references/build phases for the example iOS project. |
| example/android/gradle/wrapper/gradle-wrapper.properties | Updates the example app Gradle wrapper distribution URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,3 @@ | |||
| module.exports = { | |||
| preset: 'react-native', | |||
| preset: '@react-native/jest-preset', | |||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
joaodordio
left a comment
joaodordio
left a comment
There was a problem hiding this comment.
Same as the other PRs in this stack: can we please fill in the description with:
- the jest preset extraction (with note that example devDeps also need the new package)
@react-native/virtualized-listsstrict peer pin change (consumer impact)- metro 0.83.7 → 0.84.4
- gradle 9.0.0 → 9.3.1
| "@react-native/typescript-config": "0.84.1", | ||
| "@react-native/babel-preset": "0.85.2", | ||
| "@react-native/eslint-config": "0.85.2", | ||
| "@react-native/jest-preset": "0.85.2", |
There was a problem hiding this comment.
The new @react-native/jest-preset was added to the root devDependencies but not to the example app's devDependencies. Is that on purpose?
| "publishConfig": { | ||
| "registry": "https://registry.npmjs.org/" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Should we note in the PR description that RN 0.85 extracted @react-native/jest-preset out of react-native and that babel-jest / jest-environment-node are no longer direct deps of react-native. Anyone running the SDK without our exact devDep set may see test resolution differences.
🔹 JIRA Ticket(s) if any
✏️ Description