[SDK-482] 0-84

[lposen]

🔹 JIRA Ticket(s) if any

• SDK-482

✏️ Description

Please provide a brief description of what this pull request does.

[github-actions]

Lines	Statements	Branches	Functions
	63.07% (398/631)	40.07% (103/257)	61.5% (139/226)

[qltysh]

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

Rating	File	% Diff	Uncovered Line #s
	src/core/classes/IterableApi.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[Copilot]

Pull request overview

Updates the SDK and example app to align with React Native 0.84 (and related tooling), including changes needed for RN 0.84 TurboModule codegen constraints.

Changes:

• Bump React Native / React / RN tooling dependencies (root + example) to RN 0.84.1 and React 19.2.3.
• Adjust TurboModule TypeScript spec and iOS bridge signatures for RN 0.84+ codegen compatibility (notably removing T[] | null and loosening some object types).
• Update example app platform configs (iPad orientation key, Xcode project settings, Android buildscript dependency declaration).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
package.json	Updates devDependencies and RN/React versions for RN 0.84.x.
yarn.lock	Lockfile updates reflecting the RN/React/tooling bumps.
src/api/NativeRNIterableAPI.ts	TurboModule spec adjustments for RN 0.84+ codegen limitations.
src/core/classes/IterableApi.ts	Updates bridge calls to match the new TurboModule signature expectations.
src/core/classes/IterableConfig.ts	Moves an eslint suppression to the exact != undefined line.
ios/RNIterableAPI/RNIterableAPI.mm	Updates iOS TurboModule method signatures and simplifies embedded click forwarding.
example/package.json	Example app dependency + Node engine updates for RN 0.84.x.
example/android/build.gradle	Modifies buildscript classpath declaration for AGP.
example/ios/ReactNativeSdkExample/Info.plist	Adds iPad-specific supported orientations key.
example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj	Updates CocoaPods references and various target/build settings.
Build ReactNativeSdkExample_2026-05-12T16-27-11.txt	Adds a local build log artifact.

Comments suppressed due to low confidence (1)

src/core/classes/IterableApi.ts:653

• These params are typed as number[] | null, but the as number[] casts do not prevent null from being passed at runtime. The TurboModule spec was changed to require arrays (no null), so this can fail on the New Architecture. Also, the public docs currently state that null has semantic meaning ("do not change current value"), so replacing null with [] would be a behavior change unless the native side treats [] as null. Please either enforce non-null arrays in the JS API (and update docs/tests), or implement an explicit normalization strategy that preserves the existing null semantics.

    return RNIterableAPI.updateSubscriptions(
      emailListIds as number[],
      unsubscribedChannelIds as number[],
      unsubscribedMessageTypeIds as number[],
      subscribedMessageTypeIds as number[],

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[joaodordio]

PR description is empty. For a change this big, please add:

• breaking changes: subscriptions/embedded null handling (with link to fix discussion above)
• bundle ID change
• AGP version delegation (intentional or not)
• evidence of: example app smoke on iOS + Android, both archs; jest suite green; codegen output diff reviewed

[joaodordio]

The comment is honest about what's happening but the resulting contract is wrong. The TurboModule now declares number[] (non-null) while the public IterableApi.ts surface still accepts number[] | null, bridged by as number[] casts.

That cast silences TS but does nothing at runtime. The Iterable backend treats null as "do not change this field" and [] as "unsubscribe from everything" — those are not interchangeable. A consumer passing null today (per the documented contract) will, on the new architecture, end up unsubscribing the user from all channels of that category.

Fix should be one of:

1. Strip null at the JS layer (in IterableApi.ts) before calling RNIterableAPI. Make the public type number[] | undefined and short-circuit to a no-op when undefined.
2. Add an explicit null sentinel that the native side detects (e.g. [-1]) and converts back to nil on the Swift/Kotlin side.

Option 1 is cleaner. Either way, this needs:

• a Jest test that proves null does not become []
• a CHANGELOG entry calling out the public API change
• a paired docs PR

[joaodordio]

These casts hide a real runtime mismatch (see comment on NativeRNIterableAPI.ts). Could we replace with explicit normalization, e.g.:

if (placementIds == null) {
  // backend semantics: omit field. Either skip the call or pass a sentinel.
  return Promise.resolve([]);
}
return RNIterableAPI.getEmbeddedMessages(placementIds);

and for updateSubscriptions, drop null inputs from the args object before calling the bridge.

[joaodordio]

The AGP version was stripped ('com.android.tools.build:gradle:8.7.2' → "com.android.tools.build:gradle"). This silently delegates the AGP version to the react-native-gradle-plugin's BOM. If that's intentional for RN 0.84, please add a Groovy comment explaining why, since:

• Gradle 9 may warn on classpath deps without coordinates
• the AGP version will now float with every RN patch
• consumers customizing buildscript dependency order can hit unexpected resolutions
  If unintentional, pin to whatever AGP RN 0.84.1 ships with.