-
Notifications
You must be signed in to change notification settings - Fork 42
Fixes Xcode build issues #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes Xcode build issues #789
Conversation
|
I like that solution better than having the dynamic linkage pod installed. Can confirm it works for our setup |
@dazlious -- you would still need dynamic linkage. This is for header resolution. |
ios/RNIterableAPI/RNIterableAPI.mm
Outdated
| }; | ||
|
|
||
| #import "Iterable_React_Native_SDK-Swift.h" | ||
| #import <Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexstaravoitau. This could potentially break things depending on a users podfile setup. It would be safer for this to be conditional to account for that.
Untested pseudocode example:
#if __has_include(<Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>)
#import <Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>
#else
#import "Iterable_React_Native_SDK-Swift.h"
#endifThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, updated. 👌
Indeed, but I would not need the dynamic cocoapod plugin |
…eact-native-sdk into fix-xcode-build-issues
🔹 JIRA Ticket(s) if any
✏️ Description
Fixes Xcode build issues by switching to angled header import in
RNIterableAPI.mm.