[MOB-11551] create iterableEmbeddedMessageElements class#643
Conversation
evantk91
changed the base branch from
master
to
evan/MOB-11550-iterable-embedded-message-button-class
|
❌ 7 blocking issues (10 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,47 @@ | |||
| export class IterableEmbeddedMessageDefaultAction { | |||
There was a problem hiding this comment.
Found 2 issues:
1. Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]
2. Found 39 lines of similar code in 2 locations (mass = 76) [qlty:similar-code]
| @@ -0,0 +1,71 @@ | |||
| import { IterableEmbeddedMessageDefaultAction } from './IterableEmbeddedMessageDefaultAction'; | |||
There was a problem hiding this comment.
| constructor( | ||
| title?: string, | ||
| body?: string, | ||
| mediaUrl?: string, | ||
| mediaUrlCaption?: string, | ||
| defaultAction?: IterableEmbeddedMessageDefaultAction, | ||
| buttons?: IterableEmbeddedMessageElementsButton[], | ||
| text?: IterableEmbeddedMessageText[] |
| IterableEmbeddedMessageElementsButton.fromDict(button) | ||
| ); | ||
|
|
||
| const text = dict.text?.map((text) => |
| @@ -0,0 +1,45 @@ | |||
| export class IterableEmbeddedMessageText { | |||
There was a problem hiding this comment.
| @@ -1,2 +1,5 @@ | |||
| export * from './IterableEmbeddedManager'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,47 @@ | |||
| export class IterableEmbeddedMessageDefaultAction { | |||
There was a problem hiding this comment.
Found 2 issues:
1. Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]
2. Found 39 lines of similar code in 2 locations (mass = 76) [qlty:similar-code]
| @@ -0,0 +1,71 @@ | |||
| import { IterableEmbeddedMessageDefaultAction } from './IterableEmbeddedMessageDefaultAction'; | |||
There was a problem hiding this comment.
| constructor( | ||
| title?: string, | ||
| body?: string, | ||
| mediaUrl?: string, | ||
| mediaUrlCaption?: string, | ||
| defaultAction?: IterableEmbeddedMessageDefaultAction, | ||
| buttons?: IterableEmbeddedMessageElementsButton[], | ||
| text?: IterableEmbeddedMessageText[] |
| IterableEmbeddedMessageElementsButton.fromDict(button) | ||
| ); | ||
|
|
||
| const text = dict.text?.map((text) => |
| @@ -0,0 +1,45 @@ | |||
| export class IterableEmbeddedMessageText { | |||
There was a problem hiding this comment.
evantk91
deleted the
evan/MOB-11551-iterable-embedded-message-elements-class
branch
1 participant
🔹 JIRA Ticket(s) if any
✏️ Description