Skip to content

[MOB-11436] add serialization of placements (Android) #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evantk91 wants to merge 1 commit into from
Closed

[MOB-11436] add serialization of placements (Android) #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions android/src/main/java/com/iterable/iterableapi/RNIterableInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ public static JSONObject getInAppMessageJson(IterableInAppMessage message) {
return message.toJSONObject();
}

public static JSONObject getEmbeddedMessageJson(IterableEmbeddedMessage message) {
return IterableEmbeddedMessage.Companion.toJSONObject(message);
}

public static IterableInAppMessage getMessageById(String messageId) {
return IterableApi.getInstance().getInAppManager().getMessageById(messageId);
}
Expand Down
39 changes: 20 additions & 19 deletions android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import com.iterable.iterableapi.IterableInAppLocation;
import com.iterable.iterableapi.IterableInAppManager;
import com.iterable.iterableapi.IterableInAppMessage;
import com.iterable.iterableapi.IterableEmbeddedPlacement;
import com.iterable.iterableapi.IterableInboxSession;
import com.iterable.iterableapi.IterableLogger;
import com.iterable.iterableapi.IterableUrlHandler;
Expand Down Expand Up @@ -490,28 +491,28 @@ public void getEmbeddedPlacements(Promise promise) {
IterableLogger.d(TAG, "getEmbeddedPlacements");

// Create test data
JSONArray testPlacements = new JSONArray();
// JSONArray testPlacements = new JSONArray();
try {
// Test placement 1
JSONObject placement1 = new JSONObject();
placement1.put("placementId", 808);
testPlacements.put(placement1);
// // Test placement 1
// JSONObject placement1 = new JSONObject();
// placement1.put("placementId", 808);
// testPlacements.put(placement1);

// Test placement 2
JSONObject placement2 = new JSONObject();
placement2.put("placementId", 1121);
testPlacements.put(placement2);

// Test placement 2
JSONObject placement3 = new JSONObject();
placement3.put("placementId", 112);
testPlacements.put(placement3);

promise.resolve(Serialization.convertJsonToArray(testPlacements));
// // Test placement 2
// JSONObject placement2 = new JSONObject();
// placement2.put("placementId", 1121);
// testPlacements.put(placement2);

// // Test placement 2
// JSONObject placement3 = new JSONObject();
// placement3.put("placementId", 112);
// testPlacements.put(placement3);

JSONArray embeddedPlacementsJsonArray = Serialization.serializeEmbeddedMessages(IterableApi.getInstance().getEmbeddedManager().getMessages(1551));
promise.resolve(Serialization.convertJsonToArray(embeddedPlacementsJsonArray));
} catch (JSONException e) {

promise.reject("", "Failed to create test placements");
IterableLogger.e(TAG, e.getLocalizedMessage());
promise.reject("", "Failed to create test placements: " + e.getLocalizedMessage());
}
}

Expand Down
10 changes: 10 additions & 0 deletions android/src/main/java/com/iterable/reactnative/Serialization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.iterable.iterableapi.IterableInAppLocation;
import com.iterable.iterableapi.IterableInAppMessage;
import com.iterable.iterableapi.IterableInboxSession;
import com.iterable.iterableapi.IterableEmbeddedMessage;
import com.iterable.iterableapi.IterableLogger;
import com.iterable.iterableapi.RNIterableInternal;

Expand Down Expand Up @@ -136,6 +137,15 @@ static JSONArray serializeInAppMessages(List<IterableInAppMessage> inAppMessages
return inAppMessagesJson;
}

static JSONArray serializeEmbeddedMessages(List<IterableEmbeddedMessage> embeddedMessages) {
JSONArray embeddedMessagesJson = new JSONArray();
for (IterableEmbeddedMessage message : embeddedMessages) {
JSONObject messageJson = RNIterableInternal.getEmbeddedMessageJson(message);
embeddedMessagesJson.put(messageJson);
}
return embeddedMessagesJson;
}

static IterableConfig.Builder getConfigFromReadableMap(ReadableMap iterableContextMap) {
try {
JSONObject iterableContextJSON = convertMapToJson(iterableContextMap);
Expand Down