[MOB-8751] create embedded manager by evantk91 · Pull Request #635 · Iterable/react-native-sdk

evantk91 · 2025-05-23T18:20:56Z

🔹 JIRA Ticket(s) if any

MOB-8751

✏️ Description

This pull request

creates the IterableEmbeddedManager
creates getPlacements on IterableEmbeddedManager
creates getEmbeddedPlacements on RNIterableAPIModule and ReactIterableAPI

Testing:

native functions have hard coded dummy placements
the dev app has "get embedded messages" added to the api list under the embedded-testing branch
you can test passing through embedded placments by changing the hardcoded payload and verifying that it shows up on the app side
unit tests will be added once the embedded placement class is created on the next PR.

…ed-manager

github-actions · 2025-05-23T18:28:26Z

Lines	Statements	Branches	Functions
	38% (179/471)	11.29% (20/177)	32.05% (50/156)

qlty-cloud-legacy · 2025-05-23T18:32:04Z

❌ 4 blocking issues (4 total)

Tool	Category	Rule
eslint	Lint	Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
4	❌

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

qlty-cloud-legacy · 2025-05-23T18:32:06Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-05-23T18:32:06Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T15:43:15Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T15:43:16Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T16:59:36Z

@@ -0,0 +1,38 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T16:59:37Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T22:55:26Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T22:55:26Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T22:55:26Z

@@ -0,0 +1,2 @@
+export * from './IterableEmbeddedManager';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T23:00:04Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T23:00:04Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-02T23:00:04Z

@@ -0,0 +1,2 @@
+export * from './IterableEmbeddedManager';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-03T00:32:17Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-03T00:32:17Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-03T00:32:17Z

@@ -0,0 +1,2 @@
+export * from './IterableEmbeddedManager';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-03T00:32:17Z

@@ -0,0 +1 @@
+export * from './classes';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

lposen

Please remove the name change for the package file

lposen · 2025-06-04T19:21:13Z

@@ -15,19 +15,19 @@ __metadata:
  languageName: node


What are these changes from? There shouldn't be changes to the lock file if you just do yarn install

Im gonna make a fresh PR.

qlty-cloud-legacy · 2025-06-04T19:55:25Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:55:25Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:55:25Z

@@ -0,0 +1,2 @@
+export * from './IterableEmbeddedManager';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:55:26Z

@@ -0,0 +1 @@
+export * from './classes';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:59:33Z

@@ -0,0 +1,24 @@
+import { NativeModules } from 'react-native';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:59:33Z

@@ -0,0 +1,11 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:59:33Z

@@ -0,0 +1,2 @@
+export * from './IterableEmbeddedManager';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

qlty-cloud-legacy · 2025-06-04T19:59:33Z

@@ -0,0 +1 @@
+export * from './classes';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

lposen and others added 4 commits May 21, 2025 15:02

fix: address linting errors in embedded classes

1fc84c5

feat: adds getEmbeddedPlacements to native layers

d812d07

feat: adds getEmbeddedPlacements to RNIterableAPI

8b16063

feat: adds embedded manager to Iterable class

22528f0

evantk91 requested a review from lposen May 23, 2025 18:21

Merge branch 'evan/feature/embedded' into evan/MOB-8751-create-embedd…

c20df54

…ed-manager

qlty-cloud-legacy Bot reviewed May 23, 2025

View reviewed changes

evantk91 requested a review from Ayyanchira May 23, 2025 18:33

lposen requested changes May 28, 2025

View reviewed changes

Comment thread src/core/classes/Iterable.ts Outdated

Comment thread yarn.lock

feat: refactors getEmbeddedPlacements

f0b2138

qlty-cloud-legacy Bot reviewed Jun 2, 2025

View reviewed changes

feat: removes embeddedManager from Iterable

265896d

qlty-cloud-legacy Bot reviewed Jun 2, 2025

View reviewed changes

feat: reverts changes to package and managers

6450596

qlty-cloud-legacy Bot reviewed Jun 2, 2025

View reviewed changes

feat: revert changes to version number

d34ad14

qlty-cloud-legacy Bot reviewed Jun 2, 2025

View reviewed changes

feat: adds index files for exports

1169407

evantk91 requested a review from lposen June 3, 2025 00:30

qlty-cloud-legacy Bot reviewed Jun 3, 2025

View reviewed changes

lposen requested changes Jun 4, 2025

View reviewed changes

feat: resets yarn.lock and package.json

fe45279

qlty-cloud-legacy Bot reviewed Jun 4, 2025

View reviewed changes

Merge branch 'master' into evan/MOB-8751-create-embedded-manager

48d270a

qlty-cloud-legacy Bot reviewed Jun 4, 2025

View reviewed changes

evantk91 deleted the branch evan/feature/embedded June 4, 2025 20:26

evantk91 closed this Jun 4, 2025

evantk91 deleted the evan/MOB-8751-create-embedded-manager branch June 6, 2025 20:51

		@@ -0,0 +1,24 @@
		import { NativeModules } from 'react-native';

		@@ -0,0 +1,38 @@
		import { NativeModules } from 'react-native';

Conversation

evantk91 commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Uh oh!

github-actions Bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qlty-cloud-legacy Bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 4 blocking issues (4 total)

Uh oh!

Uh oh!

Uh oh!

qlty-cloud-legacy Bot May 23, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

lposen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lposen Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

evantk91 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy Bot Jun 4, 2025

evantk91 commented May 23, 2025 •

edited

Loading

github-actions Bot commented May 23, 2025 •

edited

Loading

qlty-cloud-legacy Bot commented May 23, 2025 •

edited

Loading