Fix docs-refresh pipeline (promote gap + snapshot step) and drop tracked .idea - #11
Merged
Merged
Conversation
pnpm 9 forwards the `--` separator through to the script, so `pnpm fetch:sources -- android` reached fetch.ts as argv ["--","android"] — process.argv[2] was "--", making it look for config/--.yml (run 30558452626). Same issue in set-source-ref.ts (positional platform/sha/label). Filter out a stray "--" in both so they work whether or not pnpm forwards it. polish-layer-a already tolerates it (regex-based arg scan). Verified locally: `pnpm fetch:sources -- android` resolves android.yml and fetches all 14 articles. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…freshes snapshot The refresh pipeline could not produce a correct refresh on its own. Two gaps: 1. polish:a wrote its output as `<slug>.layer-a.md`, but every consumer (snapshot, validate:polished, recompute:manifest) reads `<slug>.polished.md`. The `.layer-a.md` suffix was a vestige of a removed Layer-B LLM stage that v1 never runs, so nothing ever promoted layer-a → polished. A local refresh only worked via a manual `cp`. Fix: polish:a writes `.polished.md` directly, matching the Stage-2 contract in config (writes paths.polished_dir). 2. refresh-docs.yml ran polish + bumped the pin but never ran snapshot:refresh, so the auto-refresh PR would ship a stale snapshot and fail its own snapshot:verify gate in check:all. Add a Refresh snapshot step. Verified locally: fetch → polish → set-source-ref → snapshot:refresh → snapshot:verify now works with no manual step; check:all passes; regenerated corpus is byte-identical to the committed refresh except polished_at. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
.idea/ was accidentally committed earlier on this branch; add it to .gitignore and remove it from tracking. IDE config shouldn't ship in the repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the auto-refresh pipeline work end-to-end: polish:a writes
.polished.md directly (was a dead-end .layer-a.md), workflow now runs
snapshot:refresh so the auto-PR passes its own gate, plus the -- arg fix and
untracking .idea/. Verified locally: full fetch→polish→snapshot chain +
check:all green.