Skip to content

Add scrolling to cpu util table#1105

Open
Dym03 wants to merge 1 commit into
It4innovations:mainfrom
Dym03:ScrollCpuView
Open

Add scrolling to cpu util table#1105
Dym03 wants to merge 1 commit into
It4innovations:mainfrom
Dym03:ScrollCpuView

Conversation

@Dym03
Copy link
Copy Markdown
Contributor

@Dym03 Dym03 commented May 16, 2026

For bigger nodes with higher number of cpus, there might an overflow in the cpu util table. Scrolling through it handles it.
Current implementation has 2 flaws, but i think that handling them is not worth it, but let me know, the first one can be handled easily, second one could, but it wouldn't be clean I think.
Flaws:

  • 1 Wrapping of the scroll is handeled only in the way upward. Wrapping of downward selection would require storing the number of visible_cpus or rewriting the table to use the StatefulTable but i wasn't fond of this solution by the first glance.
  • 2 Right now scrolling is enabled even if it isn't needed. Solving this would require calculating how many cpus can be viewed on the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant