fix: harden SQL identifier handling across adapters#243
Merged
sujayintugle merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
sujayintugle
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden SQL identifier handling across the affected adapters and
DataProductmetadata assembly to prevent identifier-based SQL injection and stop dropping PII flags during field detail generation.Type of Change
Related Issue(s)
Fixes #216
Changes Made
DataProductfield-detail generation to quotesql_codesafely and deriveis_piifrom manifest tags instead of hardcodingFalseTesting
Test Configuration
Test Cases
Test Commands
Screenshots/Examples
Checklist
Documentation Updates
Breaking Changes
Performance Impact
Additional Context
This PR intentionally excludes unrelated local workspace changes such as
.gitignoreand.codex/.Deployment Notes
No special deployment steps required.