Generate and use static .flat files for Marlowe benchmark#7598
Open
basetunnel wants to merge 10 commits intomasterfrom
Open
Generate and use static .flat files for Marlowe benchmark#7598basetunnel wants to merge 10 commits intomasterfrom
basetunnel wants to merge 10 commits intomasterfrom
Conversation
SeungheonOh
approved these changes
Mar 18, 2026
Collaborator
SeungheonOh
left a comment
SeungheonOh
left a comment
There was a problem hiding this comment.
I haven't reviewed the actual generated UPLC flat files; however, the code for generating these looks good
Comment on lines
+20
to
+23
| import PlutusBenchmark.Marlowe.Scripts.Data.RolePayout qualified as DataRolePayout (rolePayoutValidator) | ||
| import PlutusBenchmark.Marlowe.Scripts.Data.Semantics qualified as DataSemantics (marloweValidator) | ||
| import PlutusBenchmark.Marlowe.Scripts.RolePayout qualified as RolePayout (rolePayoutValidator) | ||
| import PlutusBenchmark.Marlowe.Scripts.Semantics qualified as Semantics (marloweValidator) |
Collaborator
There was a problem hiding this comment.
nitpick:
Maybe DataRolePayout and SOPRolePayout; DataSemantics and SOPSemantics would be clearer
Collaborator
|
On a side note, since now we generate flat files for malrowe, we can also put this for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7293