refactor(stm): update PoP, protocol parameters and decoding functions

[damrobi]

Content

This PR includes an update to the handling of the proof of possession of BLS keys, a modification of the checks done on the protocol parameters and a modification to the decoding function of the merkle tree path and concatenation proof.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

Comments

Issue(s)

[github-actions]

Test Results

     5 files  ± 0     209 suites  ±0   1h 29m 7s ⏱️ - 1h 45m 59s
 3 334 tests  - 52   3 334 ✅  - 52  0 💤 ±0  0 ❌ ±0 
11 072 runs   - 49  11 072 ✅  - 49  0 💤 ±0  0 ❌ ±0 

Results for commit 7f5d023. ± Comparison against base commit 936eadd.

This pull request removes 56 and adds 4 tests. Note that renamed tests count towards both.

mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

mithril-stm ‑ proof_system::concatenation::eligibility::tests::is_lottery_won_rejects_out_of_range_phi_f
mithril-stm ‑ proof_system::halo2_snark::eligibility::tests::compute_target_value_for_snark_lottery_rejects_out_of_range_phi_f
mithril-stm ‑ protocol::key_registration::register::tests::register_by_entry_rejects_same_snark_key_with_different_concatenation_key
mithril-stm ‑ protocol::key_registration::register::tests::register_by_entry_rejects_same_verification_key_with_different_stake