fix(tests): switch tx-view test to Conway-era tx#3479
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the cardano-cli transaction view golden-file test to use Conway-era transactions now that Babbage-era transactions are no longer supported by the CLI’s view output, and normalizes the output across CLI versions by stripping the legacy update proposal field before comparison.
Changes:
- Switch
test_tx_viewto use Conway-era tx artifacts and new Conway golden output files. - Remove the CLI issue-799 probe and drop the older “redeemers/datums” output-format skip logic.
- Remove Babbage-era tx fixtures and introduce a Conway signed tx fixture; update golden JSON outputs accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cardano_node_tests/tests/test_cli.py | Uses Conway tx fixtures for transaction view and sanitizes legacy update proposal field before comparing to golden outputs. |
| cardano_node_tests/tests/data/test_tx_metadata_both_tx.signed | Removes the deprecated Babbage-era signed tx fixture. |
| cardano_node_tests/tests/data/test_tx_metadata_both_tx.body | Removes the deprecated Babbage-era tx-body fixture. |
| cardano_node_tests/tests/data/test_tx_metadata_both_tx_conway.signed | Adds a Conway-era signed tx fixture for --tx-file view testing. |
| cardano_node_tests/tests/data/test_tx_metadata_both_tx_conway_json.out | Updates the expected transaction view --tx-file JSON output for Conway. |
| cardano_node_tests/tests/data/test_tx_metadata_both_tx_conway_body_json.out | Updates the expected transaction view --tx-body-file JSON output for Conway. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Babbage-era transactions no longer supported by `cardano-cli transaction view`. Regenerate golden files from Conway txs and drop the CLI 799 issue probe. Strip the legacy `update proposal` field from view output before comparing, since newer cardano-cli omits it.
mkoura
force-pushed
the
fix_tx_view_conway_tx
branch
from
3fe5a6d to
bdc603b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babbage-era transactions no longer supported by
cardano-cli transaction view. Regenerate golden files from Conway txs and drop the CLI 799 issue probe.Strip the legacy
update proposalfield from view output before comparing, since newer cardano-cli omits it.