Skip to content

feat(tracing): vendor conway_fast cluster scripts with trace-dispatch…#3476

Draft
OlufemiAdeOlusile wants to merge 4 commits into
masterfrom
tracing-verify
Draft

feat(tracing): vendor conway_fast cluster scripts with trace-dispatch…#3476
OlufemiAdeOlusile wants to merge 4 commits into
masterfrom
tracing-verify

Conversation

@OlufemiAdeOlusile
Copy link
Copy Markdown
Collaborator

@OlufemiAdeOlusile OlufemiAdeOlusile commented May 20, 2026

Summary:

cardano-node's migration to trace-dispatcher 2.12.1 changed both the log message format and the startup behaviour of the node. This PR updates the test framework and tests to handle the new format.

Changes:

  • logfiles.py: Add Forge.Loop.DidntAdoptBlock and Startup.RpcConfigUpdateError to ERRORS_IGNORED — both are non-fatal trace-dispatcher messages that the log scanner incorrectly treated as errors
  • test_blocks.py: Update forged block log search regex from "TraceForgedBlock" (old JSON format) to Forge.Loop.ForgedBlock, and slot extraction from "slot",Number (\d+).0 to Forged block in slot (\d+) to match the new plain-text
    log format
  • Remove temporary vendored cluster_scripts/conway_fast/ — was added as a workaround while cardonnay was being updated; now that cardonnay has the correct config, it is no longer needed

Verified: Full regression (1895 passed, 0 failures, 0 errors)

…er config

Add cardano_node_tests/cluster_scripts/conway_fast/ to override the
cardonnay-installed scripts for the default regression variant.

The vendored template-config.json uses trace-dispatcher exclusively:
TraceOptions with EKGBackend, PrometheusSimple, and stdout output.
All legacy iohk-monitoring fields (hasEKG, hasPrometheus, Trace* booleans,
setupScribes, mapBackends, etc.) are removed.

Update logfiles.py to ignore Forge.Loop.DidntAdoptBlock in the new
trace-dispatcher log format, matching the existing TraceDidntAdoptBlock
entry for the legacy format.

conway_slow and mainnet_fast continue to use the cardonnay-installed scripts.
TraceForgedBlock is no longer emitted in the old iohk-monitoring JSON
format. The new trace-dispatcher log line is:

  [timestamp][host:Forge.Loop.ForgedBlock](Info,slot) Forged block in slot N

Update the regex and slot-extraction pattern in test_pool_blocks accordingly.
The temporary vendor is no longer needed now that cardonnay has the
correct trace-dispatcher config. cardano-node-tests will use the
scripts from the installed cardonnay package directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant