feat: remove context equivalence Plutus tests and related scripts#3363
Merged
feat: remove context equivalence Plutus tests and related scripts#3363
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes long-disabled Plutus “context equivalence” tests and the associated dependency chain on the archived plutus-apps create-script-context tool, simplifying the test suite and CI setup.
Changes:
- Deleted context-equivalence minting/spending tests (build and build-raw flows) and removed related constants/helpers.
- Removed the
create_script_contextutility wrapper and CI plumbing for sourcing/buildingcreate-script-context. - Cleaned up imports and removed the obsolete Plutus script artifacts used only by the deleted tests.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cardano_node_tests/utils/helpers.py | Updates tool_has docstring example away from create-script-context. |
| cardano_node_tests/utils/clusterlib_utils.py | Removes create_script_context wrapper for plutus-apps tool. |
| cardano_node_tests/tests/tests_plutus/test_spend_raw.py | Deletes spending context-equivalence test and related imports. |
| cardano_node_tests/tests/tests_plutus/test_spend_build.py | Deletes spending context-equivalence test and related imports. |
| cardano_node_tests/tests/tests_plutus/test_mint_raw.py | Deletes minting context-equivalence test and related imports/usages. |
| cardano_node_tests/tests/tests_plutus/test_mint_build.py | Deletes minting context-equivalence test and related imports/usages. |
| cardano_node_tests/tests/plutus_common.py | Removes context-equivalence script paths, costs, and the blocker-wrapper helper. |
| cardano_node_tests/tests/common.py | Removes the now-unneeded SKIPIF_MISMATCHED_ERAS marker. |
| cardano_node_tests/tests/data/plutus/v1/minting-context-equivalence-test.plutus | Deletes unused Plutus script artifact. |
| cardano_node_tests/tests/data/plutus/v1/context-equivalence-test.plutus | Deletes unused Plutus script artifact. |
| .github/source_plutus_apps.sh | Removes script that built/sourced create-script-context. |
| .github/regression.sh | Removes optional plutus-apps setup branch tied to create-script-context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
The working version of `create-script-context` tool is not available for several years, and the https://github.com/IntersectMBO/plutus-apps repo where the tool comes from is archived. The tests relying on the tool have been disabled for a long time. - Remove all tests and code related to "context equivalence" for Plutus scripts, including: - Test cases for context equivalence in minting and spending (build and build-raw flows) - Associated Plutus scripts and test data files - Helper functions and constants for context equivalence - The `.github/source_plutus_apps.sh` script and related setup logic - The `create_script_context` utility function - Clean up imports and references to removed functionality This streamlines the codebase by removing long-disabled or broken tests and dependencies on the `create-script-context` tool.
mkoura
force-pushed
the
remove_context_equivalence_tests
branch
from
9abf7af to
2bb9896
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The working version of
create-script-contexttool is not available for several years, and the https://github.com/IntersectMBO/plutus-apps repo where the tool comes from is archived. The tests relying on the tool have been disabled for a long time..github/source_plutus_apps.shscript and related setup logiccreate_script_contextutility functionThis streamlines the codebase by removing long-disabled or broken tests and dependencies on the
create-script-contexttool.