refactor: use _cli_command attribute for CLI invocation in ClusterLib#3353
Merged
refactor: use _cli_command attribute for CLI invocation in ClusterLib#3353
Conversation
Collaborator
mkoura
commented
Feb 26, 2026
mkoura
commented
- Introduce self._cli_command attribute to store the CLI command name.
- Pass constructed cli_args_strs_all directly to super().cli and set add_default_args to False to avoid duplicating default arguments.
- Introduce self._cli_command attribute to store the CLI command name. - Pass constructed cli_args_strs_all directly to super().cli and set add_default_args to False to avoid duplicating default arguments.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the custom ClusterLib.cli() wrapper so the actual invocation uses a single, consistently constructed CLI argument list (including the CLI command name), while avoiding duplicate “default args” being added by both the wrapper and the base clusterlib.ClusterLib.
Changes:
- Introduce
self._cli_commandto centralize the CLI executable name. - Build
cli_args_strs_allonce and pass it directly tosuper().cli(...). - Force
add_default_args=Falsein thesuper().cli(...)call to prevent double-prepending defaults.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.