fix(utils/submit_api): improve resubmission logging and error messages#3348
Merged
fix(utils/submit_api): improve resubmission logging and error messages#3348
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors submit_api retry loops to improve resubmission logging and make retry counts explicit, while also updating error messages to include attempt counts.
Changes:
- Add attempt counters to resubmission warning logs in
post_cborandsubmit_tx. - Replace hardcoded retry limits with named
attemptsvariables. - Update failure error messages to include the number of attempts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add attempt counters to resubmission log messages for better traceability. - Use named `attempts` variables instead of hardcoded values for clarity. - Update error messages to include the number of attempts made before failure. - Refactor loop indices for consistency and readability in `post_cbor` and `submit_tx`.
mkoura
force-pushed
the
submit_api_attempts_log
branch
from
31e1c3a to
e512062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attemptsvariables instead of hardcoded values for clarity.post_cborandsubmit_tx.