-
Notifications
You must be signed in to change notification settings - Fork 23
Switch to herald for releasing #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carbolymer
merged 2 commits into
master
from
mgalazyn/chore/migrate-to-herald-for-changelogs
May 20, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.changes/20260519_cardano_cli_friendly_tx_experimental_api.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| project: cardano-cli | ||
| pr: 1374 | ||
| kind: | ||
| - breaking | ||
| - refactoring | ||
| description: | | ||
| Migrate the friendly transaction renderer (Cardano.CLI.Compatible.Json.Friendly) off the old-API Tx/TxBody/TxBodyContent onto Exp.SignedTx/Exp.UnsignedTx. The public renderer entry points and every internal helper now use Exp.Era era and Exp.LedgerEra era. cardano-cli debug transaction view and cardano-cli transaction view now only accept Conway and Dijkstra tx/tx-body files. Pre-Conway files fail with a DeprecatedEra error. |
7 changes: 7 additions & 0 deletions
7
.changes/20260519_cardano_cli_governance_key_output_format.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| project: cardano-cli | ||
| pr: 1378 | ||
| kind: | ||
| - feature | ||
| - compatible | ||
| description: | | ||
| Add --key-output-bech32/--key-output-text-envelope to governance key-gen commands. |
6 changes: 6 additions & 0 deletions
6
.changes/20260519_cardano_cli_remove_update_proposal_flag.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| project: cardano-cli | ||
| pr: 1372 | ||
| kind: | ||
| - breaking | ||
| description: | | ||
| Remove the deprecated --update-proposal-file flag from era-based transaction build and transaction build-raw. Update proposals are deprecated since Conway and the flag was already a no-op for Conway+. The flag is kept for compatible <era> transaction signed-transaction where pre-Conway eras still need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Changelog fragment template - copy this file and fill in the fields. | ||
| # Or use 'herald new' for interactive creation. | ||
| # | ||
| # Files starting with _ are ignored by herald. | ||
| # | ||
| # Available projects and kinds are defined in .herald.yml | ||
|
|
||
| # Which project this change belongs to (see 'projects' in .herald.yml) | ||
| project: cardano-cli | ||
|
|
||
| # Pull request number associated with this change | ||
| pr: 0 | ||
|
|
||
| # One or more change kinds (see 'kinds' in .herald.yml) | ||
| kind: | ||
| # - breaking # the API has changed in a breaking way | ||
| # - feature # introduces a new feature | ||
| # - compatible # the API has changed but is non-breaking | ||
| # - bugfix # fixes a defect | ||
| # - optimisation # measurable performance improvements | ||
| # - documentation # change in code docs, haddocks | ||
| # - refactoring # code quality improvements | ||
| # - test # fixes or modifies tests | ||
| # - maintenance # not directly related to the code | ||
| # - release # related to a new release preparation | ||
| description: | | ||
| Describe your change here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,6 @@ jobs: | |
|
|
||
| steps: | ||
|
|
||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: haskell-actions/hlint-scan@v1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,88 +1,33 @@ | ||
| name: Check if PR changelog was filled correctly | ||
| name: Check changelog fragments | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| # since this is required check, we need to run it in merge_group, otherwise merge queue will stall waiting | ||
| # for a status that never arrives | ||
| merge_group: | ||
| pull_request: | ||
| types: [opened, edited, synchronize, ready_for_review] | ||
| types: [opened, synchronize, ready_for_review] | ||
|
|
||
| jobs: | ||
| check-changelog: | ||
| # Skip for merge_group: batched diffs would cause false positives and | ||
| # PR number context is unavailable. The trigger is kept so the check | ||
| # reports "skipped" (passes) when this is a required status check. | ||
| if: ${{ github.event_name != 'merge_group' }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| if: ${{ github.event_name != 'merge_group' }} | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| - run: npm install js-yaml@4.1.0 | ||
| if: ${{ github.event_name != 'merge_group' }} | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Fail if PR changelog is not correct | ||
| if: ${{ github.event_name != 'merge_group' }} | ||
| uses: actions/github-script@v7 | ||
| id: check-changelog | ||
| - uses: cachix/install-nix-action@v31 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| const yaml = require('js-yaml'); | ||
| const fs = require('fs'); | ||
|
|
||
| const prDescription = await github.rest.pulls.get({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: context.issue.number | ||
| }); | ||
|
|
||
| const changelogRegex = /# Changelog[\s\S]*?```yaml([\s\S]*?)```/; | ||
| const changelogMatch = prDescription.data.body.match(changelogRegex); | ||
| const yamlContent = changelogMatch ? changelogMatch[1].trim() : ''; | ||
| yamlContent || console.error('Failed to find changelog YAML section in the "Changelog" paragraph'); | ||
|
|
||
| try { | ||
| changelog = yaml.load(yamlContent)[0]; | ||
| } catch (e) { | ||
| console.error('Failed to parse YAML changelog as array:', yamlContent); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| try { | ||
| config = yaml.load(fs.readFileSync('.cardano-dev.yaml', 'utf8')); | ||
| } catch (e) { | ||
| console.error('Failed to load .cardano-dev.yaml config:', e); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| let isCompatibilityValid = false; | ||
| if (!changelog.compatibility) { | ||
| isCompatibilityValid = true; | ||
| } | ||
| if (!isCompatibilityValid) { | ||
| console.error('Changelog field "compatibility" is deprecated and no longer used. Please remove it.'); | ||
| } | ||
|
|
||
| let isTypeValid = false; | ||
| const validTypeValues = Object.keys(config.changelog.options.type); | ||
| if (Array.isArray(changelog.type) && !!changelog.type) { | ||
| isTypeValid = changelog.type.every(value => validTypeValues.includes(value)); | ||
| } else { | ||
| isTypeValid = validTypeValues.includes(changelog.type); | ||
| } | ||
| if (!isTypeValid) { | ||
| console.error(`PR changelog has invalid type: ${changelog.type}\nExpected one, or more of: ${validTypeValues}`) | ||
| } | ||
|
|
||
| let isDescriptionValid = true; | ||
| if (changelog.description.trim() === '<insert-changelog-description-here>') { | ||
| console.error('PR changelog description has not been updated!') | ||
| isDescriptionValid = false; | ||
| } else if (!changelog.description.trim()) { | ||
| console.error('PR changelog description field is missing!') | ||
| isDescriptionValid = false; | ||
| } | ||
|
|
||
| if (!isCompatibilityValid || !isTypeValid || !isDescriptionValid) { | ||
| console.error('Failed PR changelog checks!'); | ||
| process.exit(1); | ||
| } | ||
| extra_nix_config: | | ||
| accept-flake-config = true | ||
|
|
||
| # TODO: enable --pr check after backfilling existing PRs with fragments | ||
| - uses: input-output-hk/cardano-dev/actions/herald-validate@herald-validate-0.0.1.0 | ||
| with: | ||
| pr: false | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: Release | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| package: | ||
| description: 'Package to release (must match a project in .herald.yml)' | ||
| required: true | ||
| type: choice | ||
| options: | ||
| - cardano-cli | ||
| version: | ||
| description: 'Explicit version (A.B.C.D). Leave empty for auto-bump.' | ||
| required: false | ||
| type: string | ||
| branch: | ||
| description: 'Branch to release from and target for the PR. Leave empty to use the branch selected above.' | ||
| required: false | ||
| type: string | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ inputs.branch || github.ref_name }} | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: cachix/install-nix-action@v31 | ||
|
carbolymer marked this conversation as resolved.
|
||
| with: | ||
| extra_nix_config: | | ||
| accept-flake-config = true | ||
|
|
||
| - uses: input-output-hk/cardano-dev/actions/herald-release@herald-release-0.0.1.0 | ||
| with: | ||
| package: ${{ inputs.package }} | ||
| version: ${{ inputs.version }} | ||
| base-branch: ${{ inputs.branch || github.ref_name }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.