Remove configuration reload action in cardano-rpc server startup#1114
Merged
carbolymer merged 1 commit intomasterfrom Mar 2, 2026
Merged
Remove configuration reload action in cardano-rpc server startup#1114carbolymer merged 1 commit intomasterfrom
carbolymer merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the configuration reload action from cardano-rpc server startup, switching runRpcServer to accept a preloaded (RpcConfig, NetworkMagic) since reload is now handled via full server restart.
Changes:
- Update
runRpcServersignature to take(RpcConfig, NetworkMagic)instead of anIOreload action. - Inline destructuring of the configuration tuple in
runRpcServer. - Remove outdated TODO/comment about logging on config reload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eb622bc to
0c7a5bc
Compare
Jimbo4350
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This is not needed anymore, as configuration reload is implemented as whole server restart:
Checklist