Skip to content

Remove configuration reload action in cardano-rpc server startup#1114

Merged
carbolymer merged 1 commit intomasterfrom
mgalazyn/chore/remove-config-reload-action
Mar 2, 2026
Merged

Remove configuration reload action in cardano-rpc server startup#1114
carbolymer merged 1 commit intomasterfrom
mgalazyn/chore/remove-config-reload-action

Conversation

@carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 26, 2026

Changelog

- description: |
    Remove configuration reload action in cardano-rpc server startup
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
# uncomment at least one main project this PR is associated with
  projects:
  # - cardano-api
  # - cardano-api-gen
   - cardano-rpc
  # - cardano-wasm

Context

This is not needed anymore, as configuration reload is implemented as whole server restart:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copilot AI review requested due to automatic review settings February 26, 2026 16:28
@carbolymer carbolymer self-assigned this Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the configuration reload action from cardano-rpc server startup, switching runRpcServer to accept a preloaded (RpcConfig, NetworkMagic) since reload is now handled via full server restart.

Changes:

  • Update runRpcServer signature to take (RpcConfig, NetworkMagic) instead of an IO reload action.
  • Inline destructuring of the configuration tuple in runRpcServer.
  • Remove outdated TODO/comment about logging on config reload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-config-reload-action branch from eb622bc to 0c7a5bc Compare March 2, 2026 14:41
@carbolymer carbolymer added this pull request to the merge queue Mar 2, 2026
Merged via the queue into master with commit 0856ba4 Mar 2, 2026
32 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/remove-config-reload-action branch March 2, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants