[Fix] Align Qwen3.5 tests with Transformers 5.14.1 - #2009
Open
jayhenry wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines the minimal collection workaround from #2008 with the Transformers 5.14.1 compatibility fixes diagnosed in #2002, without migrating the wider test suite away from third-party
parametrize.test_qwen3_tile_embedding.pyRoot causes
Collection failure
Third-party
parametrize==0.1.1recursively scans module objects in decorator-frame globals. The top-leveltransformerslazy module can populate its dictionary during that scan, causingRuntimeError: dictionary changed size during iteration.The module import in
test_qwen3_tile_embedding.pywas unused. Importing only the concreteAutoTokenizersymbol avoids exposing the lazy module to this scan while retaining the current parameterization framework.Transformers 5.14.1 compatibility
get_vision_bilinear_indices_and_weightsValidation
Using
pt29_glm2, variables fromzdev/env.sh, andgpu_lock.shfor GPU tests:41 tests collected5 passed3 passed2 passed2 passedparametrizewith module-levelimport transformersgit diff --check: passedThe previous Action completed with
558 passed, 18 skipped, 1 failed; the sole failure was the stale chat-template expectation fixed by commit9be88872.The full local suite was intentionally not run. Full HF video-reference cases require the CI TorchCodec/FFmpeg environment and are covered by the triggered Action.