spec: a child collection can outlive its master's lock - #9
Merged
Conversation
An entity's immutability covers THAT entity, but the specification never said whether it reaches a composition child - so a generator could freeze every child collection of a locked master and still claim conformance. That is what one did: an issued invoice's payment allocations became unreachable exactly when allocations start to matter, even though the child's own write surface accepted them. Adds `locksWithMaster` (default true) and states the boundary normatively, including the half that is easy to miss: the prohibition covers the AFFORDANCES a generator renders, not only the writes it accepts - a read-only rendering of something the server would have permitted is the same defect as a refused write. Requires a composition child of a master that actually locks, and must be rejected elsewhere rather than ignored: an inert declaration is indistinguishable from a working one until someone needs it. A document's own line items are unaffected - they are the content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entity's immutability covers that entity, but the specification never said whether it reaches a composition child — so a generator could freeze every child collection of a locked master and still claim conformance.
That is what one did: an issued invoice's payment allocations became unreachable exactly when allocations start to matter, even though the child's own write surface accepted them (verified: master
mutable:falseand a header PUT 409, while a POST to the child controller returned 200 and the roll-up recomputed).Change
Adds
locksWithMaster(default true, so nothing changes for a model that says nothing):Content and settlement are different lifecycles on the same document.
The normative half that is easy to miss
Plus: it is only meaningful on a composition child of a master that actually locks, and MUST be rejected elsewhere rather than ignored — an inert declaration is indistinguishable from a working one until someone needs it. A document's own line items are unaffected; they are the content.
Reference implementation
eclipse-dirigible/dirigible#6700.
🤖 Generated with Claude Code