ci: pin softprops/action-gh-release to SHA in deploy workflow#198
Closed
BenjaminMichaelis wants to merge 2 commits into
Closed
ci: pin softprops/action-gh-release to SHA in deploy workflow#198BenjaminMichaelis wants to merge 2 commits into
BenjaminMichaelis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Pins
softprops/action-gh-releaseto a specific commit SHA in the deploy workflow, rather than a floatingv3tag.Before:
After:
Why
Floating version tags (e.g.
@v3) can be silently moved by the action author to point at a different — potentially malicious — commit. Pinning to a SHA ensures the workflow always runs the exact code that was reviewed, regardless of what the tag points to in the future. This is a GitHub security best practice for third-party actions.The rest of the deploy workflow (
NuGet/login@v1,actions/*) was already using either first-party actions or a trusted pinned action, so no other changes were needed.Context
This was part of setting up NuGet trusted publishing (OIDC) for
IntelliTect.Multitool. The deploy workflow already hadid-token: writeandNuGet/login@v1correctly configured — this PR just hardens the one remaining unpinned third-party action.