Move build system to meson-python - #166
Open
ndgrigorian wants to merge 65 commits into
Open
Conversation
ndgrigorian
force-pushed
the
build-with-meson
branch
2 times, most recently
from
March 4, 2026 11:09
1434bc2 to
5e8ef5a
Compare
ndgrigorian
force-pushed
the
add-pre-commit
branch
from
March 5, 2026 00:18
52b0dcf to
e73dc73
Compare
ndgrigorian
force-pushed
the
build-with-meson
branch
17 times, most recently
from
March 5, 2026 07:29
5c09809 to
b469c01
Compare
ndgrigorian
marked this pull request as ready for review
March 5, 2026 08:01
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
March 5, 2026 08:01
ndgrigorian
force-pushed
the
build-with-meson
branch
from
March 5, 2026 08:10
b469c01 to
787c5cb
Compare
ndgrigorian
force-pushed
the
add-pre-commit
branch
from
March 5, 2026 09:19
e73dc73 to
6f05c5c
Compare
ndgrigorian
force-pushed
the
build-with-meson
branch
from
March 5, 2026 09:22
787c5cb to
ef4cb58
Compare
An error occurred while trying to automatically change base from
add-pre-commit
to
main
March 5, 2026 15:29
ndgrigorian
force-pushed
the
build-with-meson
branch
from
March 5, 2026 21:34
ef4cb58 to
72232cb
Compare
antonwolfy
reviewed
Jul 28, 2026
antonwolfy
reviewed
Jul 29, 2026
| # Perform regular install | ||
| ${PYTHON} setup.py install "${SKBUILD_ARGS[@]}" | ||
| fi | ||
| $PYTHON -m pip install --no-build-isolation --no-deps -Csetup-args="-Dmkl_threading=gnu_thread" . |
Collaborator
There was a problem hiding this comment.
Is that intended to move from Intel compiler to GCC in cf workflows?
Looking into PR where we proposed to add mkl_umath to the cf feedstock, we still used Intel compiler there.
Collaborator
Author
There was a problem hiding this comment.
We were discussing it in general, but it may be best to do it separately after we confirm that it introduces no performance regressions
Collaborator
There was a problem hiding this comment.
I have restored the Intel compiler as it was before
I agree with @ndgrigorian that GCC switch should be done separately because with Intel compiler we pass optimization flags -fveclib=SVML, -fimf-precision=high, -fvectorize so we need to check performance regressions first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes moving from scikit-build to meson-python as the mkl_umath build system
meson-python is already used by NumPy and eliminates the need for CMake, while also allowing setup.py to be removed (with its logic moved into the meson.build script)
Following the approach in NumPy,
vendored/process_src_template.pyis vendored from NumPy to be called from the build script, automating the processing ofconv_template.pyThis PR also adds building and testing with standard clang
Build option also changes:
The former CMake build options are now exposed as meson options and passed via
-Csetup-args:OPTIMIZATION_REPORTbecomes-Csetup-args=-Dopt_report=trueMKL_THREADINGbecomes-Csetup-args=-Dmkl_threading=<layer>