Conversation
These predate PR #97 but surface in the project-wide issue list: - 2 × python:S1192 in mcp_server/server.py: extracted _ERR_ACTIONS_LIST and _ERR_TEXT_STRING module constants (literal "'actions' must be a list" appeared 4x; "'text' must be a string" appeared 3x) - python:S5869 in md_authoring/markdown_to_actions.py _TEMPLATE_RE: with re.IGNORECASE, [A-Za-z_] has a duplicate range — replaced with [A-Z_] (lowercase folds via the flag); dropped the misplaced NOSONAR - python:S8513 in visual_review/review_server.py: collapsed `startswith("/img/baseline/") or startswith("/img/current/")` into the single-call tuple form - python:S8520 in test_sharding.py: replaced `sum(parts, [])` flatten with `list(itertools.chain.from_iterable(parts))` - text:S8565 in pyproject.toml (missing lock file): generated uv.lock via `uv lock` to pin all 26 transitive dependencies (project still builds with setuptools; uv.lock just documents resolved versions) All 2920 unit tests pass.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single follow-up commit (
1f9b5f9) addressing the 6 project-wideSonarCloud issues that surfaced after PR #97 merged.
mcp_server/server.py_ERR_ACTIONS_LISTand_ERR_TEXT_STRINGmodule constants (7 call sites updated)md_authoring/markdown_to_actions.py[A-Za-z_]→[A-Z_](withre.IGNORECASE— same match set, no class duplication)visual_review/review_server.pystartswithcalls collapsed into single tuple-arg formtest/unit_test/test_sharding.pysum(parts, [])→list(chain.from_iterable(parts))pyproject.tomluv.lockviauv lockto pin all 26 resolved depsThe
uv.lockfile is the bulk of the diff (+503 lines) and documentsthe resolved dependency graph; the project still builds via setuptools.
Test plan
python -m pytest test/unit_test/test_*.py— 2920 pass, 3 skiptest_dev.yml/test_stable.yml/e2e_browser.yml