Skip to content

fix(a11y): make artwork lightbox triggers and interactive rows keyboard-accessible #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InstaZDLL merged 6 commits into from
May 20, 2026

fix(library): add role=button + onKeyUp Space guard to interactive rows

8713cea
Select commit
Loading
Failed to load commit list.
Merged

fix(a11y): make artwork lightbox triggers and interactive rows keyboard-accessible #69

fix(library): add role=button + onKeyUp Space guard to interactive rows
8713cea
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action May 20, 2026 in 0s

19 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 15
- Added 19
           

Complexity increasing per file
==============================
- src/components/layout/QueuePanel.tsx  11
- src/components/views/AlbumDetailView.tsx  8
- src/components/views/LibraryView.tsx  3
         

Clones added
============
- src/components/layout/QueuePanel.tsx  1
- src/components/views/AlbumDetailView.tsx  2
- src/components/views/GenreDetailView.tsx  2
- src/components/views/LikedView.tsx  3
         

Clones removed
==============
+ src/components/views/WrappedView.tsx  -2

See the complete overview on Codacy

Annotations

Check warning on line 249 in src/components/layout/LyricsPanel.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/layout/LyricsPanel.tsx#L249 

This JSX attribute is specific to React.

Check warning on line 147 in src/components/layout/NowPlayingPanel.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/layout/NowPlayingPanel.tsx#L147 

This JSX attribute is specific to React.

Check warning on line 534 in src/components/layout/QueuePanel.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/layout/QueuePanel.tsx#L534 

The elements with this role can be changed to the following elements:
<button>

Check warning on line 549 in src/components/layout/QueuePanel.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/layout/QueuePanel.tsx#L549 

This JSX attribute is specific to React.

Check warning on line 175 in src/components/player/FullscreenLyrics.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/player/FullscreenLyrics.tsx#L175 

This JSX attribute is specific to React.

Check warning on line 222 in src/components/views/AlbumDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/AlbumDetailView.tsx#L222 

This JSX attribute is specific to React.

Check warning on line 241 in src/components/views/AlbumDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/AlbumDetailView.tsx#L241 

This JSX attribute is specific to React.

Check warning on line 475 in src/components/views/AlbumDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/AlbumDetailView.tsx#L475 

The HTML element li is non-interactive and should not have an interactive role.

Check warning on line 475 in src/components/views/AlbumDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/AlbumDetailView.tsx#L475 

The elements with this role can be changed to the following elements:
<button>

Check warning on line 491 in src/components/views/AlbumDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/AlbumDetailView.tsx#L491 

This JSX attribute is specific to React.

Check warning on line 262 in src/components/views/ArtistDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/ArtistDetailView.tsx#L262 

This JSX attribute is specific to React.

Check warning on line 285 in src/components/views/GenreDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/GenreDetailView.tsx#L285 

The HTML element li is non-interactive and should not have an interactive role.

Check warning on line 285 in src/components/views/GenreDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/GenreDetailView.tsx#L285 

The elements with this role can be changed to the following elements:
<button>

Check warning on line 300 in src/components/views/GenreDetailView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/GenreDetailView.tsx#L300 

This JSX attribute is specific to React.

Check warning on line 157 in src/components/views/LikedView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/LikedView.tsx#L157 

The HTML element li is non-interactive and should not have an interactive role.

Check warning on line 157 in src/components/views/LikedView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/LikedView.tsx#L157 

The elements with this role can be changed to the following elements:
<button>

Check warning on line 176 in src/components/views/LikedView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/LikedView.tsx#L176 

This JSX attribute is specific to React.

Check warning on line 1111 in src/components/views/PlaylistView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/PlaylistView.tsx#L1111 

The elements with this role can be changed to the following elements:
<button>

Check warning on line 1127 in src/components/views/PlaylistView.tsx

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/components/views/PlaylistView.tsx#L1127 

This JSX attribute is specific to React.
View more details on Codacy Production