ENH: Restore itkYvvBenchmark3D with ITKTestingData CID content-link#6265
ENH: Restore itkYvvBenchmark3D with ITKTestingData CID content-link#6265hjmjohnson wants to merge 1 commit into
Conversation
Reverses the partial drop in c2940bf ("BUG: Drop itkYvvBenchmark3D — input fixture 256x256x64.tif not available"). The fixture is now published in ITKTestingData as CID bafkreihivrgyltvbk7qsdgxvuknyikkfnxijm6wgya66zi5zzjmyiei3da (ITKTestingData PR InsightSoftwareConsortium#49, merged), so the 3D benchmark can resolve DATA{Input/256x256x64.tif} via ExternalData. Restores: * Input/256x256x64.tif.cid — content-link to the published fixture. * itk_add_test(NAME itkYvvBenchmark3D ...) in test/CMakeLists.txt, invoking itkYvvBenchmark with size=3, sigma=12.0, iterations=2 on the 256x256x64.tif input (4.0 MiB, sha256 e8ac4d85cea157e1219af5a29b8429456dd0967ac6c03deca3b9ca5984111b18).
|
| Filename | Overview |
|---|---|
| Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/test/CMakeLists.txt | Restores the itkYvvBenchmark3D test block; parameters and DATA{} reference are consistent with the 2D benchmark and the new .cid fixture. |
| Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/test/Input/256x256x64.tif.cid | New CID content-link file; CIDv1 format matches all other .cid files in the repo, trailing newline present. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["cmake configure\n(Module_SmoothingRecursiveYvvGaussianFilter=ON)"] --> B["ExternalData sees\nDATA{Input/256x256x64.tif}"]
B --> C["Reads 256x256x64.tif.cid\nbafkreihivr…"]
C --> D{"Blob in\nlocal cache?"}
D -- Yes --> E["Symlink object\n→ build tree"]
D -- No --> F["Fetch from\nITKTestingData CID store"]
F --> E
E --> G["ctest -R itkYvvBenchmark3D\nitkYvvBenchmark size=3 sigma=12.0 iters=2"]
G --> H["Test passes"]
Reviews (1): Last reviewed commit: "ENH: Restore itkYvvBenchmark3D with ITKT..." | Re-trigger Greptile
Restores the
itkYvvBenchmark3Dtest that was dropped in commit c2940bf (part of PR #6243) because the input fixture256x256x64.tifwas not yet published. The fixture has since been published in ITKTestingData PR #49 (merged) under CIDbafkreihivrgyltvbk7qsdgxvuknyikkfnxijm6wgya66zi5zzjmyiei3da, so the test can now resolveDATA{Input/256x256x64.tif}via ExternalData.Test plan
Module_SmoothingRecursiveYvvGaussianFilter=ON(the module isEXCLUDE_FROM_DEFAULT).SmoothingRecursiveYvvGaussianFilterTestDriver— clean link.ITK_DATA_CACHE/CID/bafkreihivr….ctest -R '^itkYvvBenchmark3D$'— passed in 0.21s.pre-commit run --all-filesclean on post-commit tree.What this PR changes
Two-file change (+12 / -0):
Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/test/Input/256x256x64.tif.cid— new content-link file with the ITKTestingData CID.Modules/Filtering/SmoothingRecursiveYvvGaussianFilter/test/CMakeLists.txt— restores theitk_add_test(NAME itkYvvBenchmark3D …)block, invokingitkYvvBenchmarkwithsize=3,sigma=12.0,iterations=2on the 256×256×64 input.The drop in c2940bf retained 3D coverage via
itkYvvWhiteImageTest3Dand the GPU 3D filter test; this PR adds back the benchmark variant that exercises the recursive Yvv-Gaussian filter on a real medical-imaging-shaped volume.