docs: AGENTS.md + CLAUDE.md; enrich developing-insta-cli#35
Conversation
Add a repo-local CLAUDE.md (always-on rules + pointer to the skill) and fold a src/ architecture map + the cli-reference.md sync rule into the existing developing-insta-cli skill. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jwfing
left a comment
There was a problem hiding this comment.
Summary
Docs-only PR adding an always-on CLAUDE.md and folding a src/ architecture map + cli-reference sync rule into the developing-insta-cli skill; tightly scoped (+40/−0, 2 files) and accurate apart from a couple of gaps in the command-group enumeration.
Requirements context
No matching spec/plan found — this repo has no docs/superpowers/ (nor a docs/ directory at all), so I assessed against the PR description alone plus the actual src/ tree at head (51387c8). The PR's own stated intent is "orientation layer without duplicating the existing skill," and the doc explicitly positions the command surface as "how agents learn the CLI" — so I checked the map against the real source.
Findings
Critical
(none)
Suggestion
- Functionality / accuracy —
commands/row omits two real command groups..claude/skills/developing-insta-cli/SKILL.md:29states "one file per command group" and then enumeratesauth org project services branch secrets deploy compute upgrade metrics (+logs) billing govern manifest observe. Butsrc/commands/also containsrun.tsandsetup.ts, both imported and registered inindex.ts(run <cmd> [args...]atsrc/index.ts:62, importedsrc/index.ts:8;setupgroup atsrc/index.ts:68, importedsrc/index.ts:7). Since the doc's purpose is to be the authoritative source-tree map for agents, an incomplete "one file per group" list will mislead. Please addrunandsetup.
Information
resolve-project.tsnot in the architecture table. The table (SKILL.md:24-31) maps thesrc/top level but omitssrc/resolve-project.ts(a distinct module used bysrc/api.ts), whileutil.tsgets its own row. Minor — worth a row or a note if the table is meant to be exhaustive.- Node version phrasing.
CLAUDE.md:4says "Node 20 + TS (ESM)", whereaspackage.jsonenginesisnode: ">=18". Not a contradiction (20 satisfies ≥18), but "Node 20" reads as a hard requirement; consider aligning the wording withengines(or noting 20 as the CI/target runtime). - Verified-accurate, for the record:
metrics (+logs)correctly reflects thatlogs(src/index.ts:144) is implemented inmetrics.ts(both route through theobsimport atsrc/index.ts:19) rather than its own file; and the pre-commit gatenpm run typecheck && npm test(CLAUDE.md:14) matches thetypecheckandtestscripts inpackage.json.
Software engineering
Scope is clean — one concern, docs-only, no code touched, no drive-by edits; naming (developing-insta-cli, CLAUDE.md) follows existing repo/superproject convention. No tests are applicable to a docs change.
Security
No security-relevant changes — no code, no user input, no secrets, no auth logic touched.
Performance
Not applicable — documentation only.
Verdict
approved (informational — zero Critical findings). The two Suggestion/Information accuracy nits on the command-group list are worth a quick follow-up but are non-blocking. Human approval still required via the normal GitHub approve flow.
Split repo-local agent notes into AGENTS.md (read by Claude Code, Codex, and other AGENTS.md-aware tools); CLAUDE.md imports it via @AGENTS.md, matching the frontend/ convention. The developing-* skill stays in .claude/skills/ (Claude Code's skill dir); AGENTS.md points to the SKILL.md file so other agents can read it directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Per-repo agent context; keeps the existing
developing-insta-cliskill as canonical.What
AGENTS.md— always-on rules (main protected → PR-only/squash/1 review,feat/*/fix/*off main, submodule commit-order, pre-commit gate, mirror command changes intoskills/insta/cli-reference.md) + a pointer to the skill. Read by Claude Code, Codex, and other AGENTS.md-aware tools.CLAUDE.md—@AGENTS.md(matches thefrontend/convention).developing-insta-cliskill — folded in asrc/architecture map + the cli-reference sync rule it lacked. Existing dev-loop / PR-approval / release content unchanged.Naming follows this repo's existing
developing-insta-cli(other insta-cloud submodules usedeveloping-on-<module>).🤖 Generated with Claude Code