fix/fix_stream_prices_example_script

[aarmoa]

• Updated the oracle stream prices script to send the oracle typealways in lowercase

Summary by CodeRabbit

• Refactor
  • Enhanced the handling of configuration values for price updates by standardizing inputs to lower-case, which improves consistency and reliability.

[coderabbitai]

Walkthrough

The update modifies the handling of the oracle_type variable in the main function of the 1_StreamPrices.py example. Instead of using the oracle_type value directly from market, the code now converts the value to lowercase before it is passed to client.listen_oracle_prices_updates. The rest of the asynchronous structure and error handling remains unchanged.

Changes

File(s)	Change Summary
examples/exchange_client/oracle_rpc/1_StreamPrices.py	Modified oracle_type processing by converting its value to lowercase before usage in listen method.

Sequence Diagram(s)

sequenceDiagram
    participant Main as main()
    participant Market as market
    participant Client as client.listen_oracle_prices_updates

    Main->>Market: Retrieve oracle_type
    Market-->>Main: Return oracle_type
    Main->>Main: Convert oracle_type to lowercase
    Main->>Client: Pass processed oracle_type to listen_oracle_prices_updates

Loading

Poem

I hopped through lines of code so neat,
Changing oracle_type with a lowercase beat.
My whiskers tremble with joyful flair,
As errors vanish into thin air.
CodeRabbit cheers—hopping without a care! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

examples/exchange_client/oracle_rpc/1_StreamPrices.py (1)

32-32: Consider adding validation and documentation.

To improve robustness and maintainability:

1. Add validation to handle potential None values
2. Document why lowercase is required

+    # Oracle type must be lowercase for the API
+    if market.oracle_type is None:
+        raise ValueError("Oracle type is required")
     oracle_type = market.oracle_type.lower()

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b09a7a0 and 65ce48e.

📒 Files selected for processing (1)

• examples/exchange_client/oracle_rpc/1_StreamPrices.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: run-tests (3.11, windows-latest)
• GitHub Check: run-tests (3.10, windows-latest)
• GitHub Check: run-tests (3.9, windows-latest)

🔇 Additional comments (1)

examples/exchange_client/oracle_rpc/1_StreamPrices.py (1)

32-32: LGTM! Change aligns with PR objective.

The conversion of oracle_type to lowercase ensures consistent format for the API call.