chore: chain v1.20.3 release - #188
Open
dbrajovic wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughThe documentation schemas add spot-trade notional and expanded derivative RPC fields. RFQ descriptions and generated error-table includes are updated, while Makefile clone targets select newer repository and SDK versions. ChangesSpot trade notional schemas
Derivative RPC schemas
RFQ documentation descriptions
Generated error documentation
Repository clone revisions
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@source/json_tables/indexer/injective_tc_derivatives_rpc/MarketsRequest.json`:
- Around line 21-24: Add a clear description to the market_ids parameter in
MarketsRequest, stating that it filters by market IDs.
In
`@source/json_tables/indexer/injective_tc_derivatives_rpc/PerpetualMarketFunding.json`:
- Around line 8-10: Update the Description for the cumulative_price parameter to
remove the duplicated “Defines,” so it reads “Defines the cumulative price...”
before reference documentation generation.
In
`@source/json_tables/indexer/injective_tc_derivatives_rpc/PerpetualMarketInfo.json`:
- Around line 18-20: Update the funding_interval description in
PerpetualMarketInfo to remove the duplicated “in seconds” phrase, using the
wording “Defines the funding interval of a perpetual market in seconds.”
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9081bb7d-f9f3-48da-9e6b-ae4789b34809
📒 Files selected for processing (18)
Makefilesource/includes/_errors.mdsource/json_tables/indexer/injective_derivative_exchange_rpc/DerivativePositionV2.jsonsource/json_tables/indexer/injective_rfq_rpc/ConditionalOrderResponseType.jsonsource/json_tables/indexer/injective_rfq_rpc/ListSettlementRequest.jsonsource/json_tables/indexer/injective_rfq_rpc/StreamSettlementRequest.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/DerivativeMarketInfo.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/DerivativePositionV2.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/ExpiryFuturesMarketInfo.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/MarketsRequest.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/MarketsResponse.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/OpenNotionalCap.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/PerpetualMarketFunding.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/PerpetualMarketInfo.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/StreamTradesRequest.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/TCDerivativeTrade.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/TokenMeta.jsonsource/json_tables/indexer/injective_tc_derivatives_rpc/TradesRequest.json
💤 Files with no reviewable changes (1)
- source/includes/_errors.md
Comment on lines
+21
to
+24
| "Parameter": "market_ids", | ||
| "Type": "string array", | ||
| "Description": "", | ||
| "Required": "Yes" |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document market_ids.
Line 23 is empty, so consumers cannot tell what the array filters. Add a description such as “Filter by market IDs.”
📝 Proposed fix
"Parameter": "market_ids",
"Type": "string array",
- "Description": "",
+ "Description": "Filter by market IDs",
"Required": "Yes"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Parameter": "market_ids", | |
| "Type": "string array", | |
| "Description": "", | |
| "Required": "Yes" | |
| "Parameter": "market_ids", | |
| "Type": "string array", | |
| "Description": "Filter by market IDs", | |
| "Required": "Yes" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@source/json_tables/indexer/injective_tc_derivatives_rpc/MarketsRequest.json`
around lines 21 - 24, Add a clear description to the market_ids parameter in
MarketsRequest, stating that it filters by market IDs.
Comment on lines
+8
to
+10
| "Parameter": "cumulative_price", | ||
| "Type": "string", | ||
| "Description": "Defines defines the cumulative price for the current hour up to the last timestamp." |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the duplicated word in cumulative_price documentation.
Line 10 renders “Defines defines”; change it to “Defines the cumulative price...” before generating the reference docs.
📝 Proposed fix
- "Description": "Defines defines the cumulative price for the current hour up to the last timestamp."
+ "Description": "Defines the cumulative price for the current hour up to the last timestamp."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Parameter": "cumulative_price", | |
| "Type": "string", | |
| "Description": "Defines defines the cumulative price for the current hour up to the last timestamp." | |
| "Parameter": "cumulative_price", | |
| "Type": "string", | |
| "Description": "Defines the cumulative price for the current hour up to the last timestamp." |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@source/json_tables/indexer/injective_tc_derivatives_rpc/PerpetualMarketFunding.json`
around lines 8 - 10, Update the Description for the cumulative_price parameter
to remove the duplicated “Defines,” so it reads “Defines the cumulative
price...” before reference documentation generation.
Comment on lines
+18
to
+20
| "Parameter": "funding_interval", | ||
| "Type": "int64", | ||
| "Description": "Defines the funding interval in seconds of a perpetual market in seconds." |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the duplicated unit phrase in funding_interval.
Line 20 says “in seconds ... in seconds”; simplify it to “Defines the funding interval of a perpetual market in seconds.”
📝 Proposed fix
- "Description": "Defines the funding interval in seconds of a perpetual market in seconds."
+ "Description": "Defines the funding interval of a perpetual market in seconds."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Parameter": "funding_interval", | |
| "Type": "int64", | |
| "Description": "Defines the funding interval in seconds of a perpetual market in seconds." | |
| "Parameter": "funding_interval", | |
| "Type": "int64", | |
| "Description": "Defines the funding interval of a perpetual market in seconds." |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@source/json_tables/indexer/injective_tc_derivatives_rpc/PerpetualMarketInfo.json`
around lines 18 - 20, Update the funding_interval description in
PerpetualMarketInfo to remove the duplicated “in seconds” phrase, using the
wording “Defines the funding interval of a perpetual market in seconds.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation