Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core
Submodule Core updated 53 files
+0 −4 AppIntegrity/lint-baseline.xml
+0 −4 AppLock/lint-baseline.xml
+0 −4 AppVersionChecker/lint-baseline.xml
+0 −4 Auth/lint-baseline.xml
+0 −4 Avatar/lint-baseline.xml
+0 −4 BugTracker/lint-baseline.xml
+0 −4 Coil/lint-baseline.xml
+0 −4 Common/lint-baseline.xml
+0 −4 CrossAppLogin/Back/lint-baseline.xml
+4 −0 CrossAppLogin/Front/build.gradle.kts
+0 −4 DotLottie/lint-baseline.xml
+0 −4 File/lint-baseline.xml
+0 −4 FileTypes/lint-baseline.xml
+0 −4 FragmentNavigation/lint-baseline.xml
+0 −4 InAppReview/lint-baseline.xml
+4 −0 InAppUpdate/build.gradle.kts
+4 −0 KSuite/KSuitePro/build.gradle.kts
+4 −0 KSuite/MyKSuite/build.gradle.kts
+0 −4 KSuite/lint-baseline.xml
+0 −4 Ktor/lint-baseline.xml
+0 −5 Legacy/Confetti/lint-baseline.xml
+0 −5 Legacy/lint-baseline.xml
+0 −4 Matomo/lint-baseline.xml
+0 −4 Network/Ktor/lint-baseline.xml
+0 −4 Network/Models/lint-baseline.xml
+0 −4 Network/lint-baseline.xml
+0 −4 Notifications/Registration/lint-baseline.xml
+0 −4 Notifications/lint-baseline.xml
+4 −0 Onboarding/build.gradle.kts
+0 −4 PrivacyManagement/lint-baseline.xml
+0 −4 RecyclerView/lint-baseline.xml
+0 −4 Sentry/lint-baseline.xml
+0 −4 SharedValues/lint-baseline.xml
+0 −4 Thumbnails/lint-baseline.xml
+0 −4 TwoFactorAuth/Back/WithUserDb/lint-baseline.xml
+0 −4 TwoFactorAuth/Back/lint-baseline.xml
+4 −0 TwoFactorAuth/Front/build.gradle.kts
+0 −4 Ui/Compose/AccountBottomSheet/lint-baseline.xml
+0 −4 Ui/Compose/BasicButton/lint-baseline.xml
+0 −4 Ui/Compose/Basics/lint-baseline.xml
+4 −0 Ui/Compose/BottomStickyButtonScaffolds/build.gradle.kts
+0 −4 Ui/Compose/Margin/lint-baseline.xml
+0 −4 Ui/Compose/MaterialThemeFromXml/lint-baseline.xml
+4 −0 Ui/Compose/Preview/build.gradle.kts
+0 −4 Ui/Compose/Theme/lint-baseline.xml
+0 −4 Ui/View/EdgeToEdge/lint-baseline.xml
+0 −4 Ui/View/lint-baseline.xml
+0 −4 Ui/lint-baseline.xml
+0 −4 WebView/lint-baseline.xml
+1 −1 build-logic/composeLint/README.md
+0 −4 build-logic/composeLint/src/main/kotlin/com/infomaniak/core/compose/lint/ComposeLintPlugin.kt
+5 −1 build.gradle.kts
+1 −0 gradle/core.versions.toml
4 changes: 4 additions & 0 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ android {
androidResources {
generateLocaleConfig = true
}

lint {
baseline = file("lint-baseline.xml")
}
}

val isRelease = gradle.startParameter.taskNames.any { it.contains("release", ignoreCase = true) }
Expand Down
35 changes: 1 addition & 34 deletions app/lint-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.13.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0)" variant="all" version="8.13.0">

<issue
id="ComposeViewModelInjection"
message="Implicit dependencies of composables should be made explicit.&#xA;Usages of hiltViewModel to acquire a ViewModel should be done in composable default parameters, so that it is more testable and flexible.&#xA;See https://slackhq.github.io/compose-lints/rules/#viewmodels for more information."
errorLine1=" val appSettingsViewModel: AppSettingsViewModel = hiltViewModel&lt;AppSettingsViewModel>()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/com/infomaniak/auth/ui/screen/settings/SettingsScreen.kt"
line="48"
column="5"/>
</issue>

<issue
id="ComposeViewModelInjection"
message="Implicit dependencies of composables should be made explicit.&#xA;Usages of hiltViewModel to acquire a ViewModel should be done in composable default parameters, so that it is more testable and flexible.&#xA;See https://slackhq.github.io/compose-lints/rules/#viewmodels for more information."
Expand All @@ -30,21 +19,10 @@
errorLine2="^">
<location
file="src/main/kotlin/com/infomaniak/auth/ui/components/StatusCard.kt"
line="120"
line="121"
column="1"/>
</issue>

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [modifier: Modifier = Modifier, securityLevel: AccountSecurityLevel] but should be [securityLevel: AccountSecurityLevel, modifier: Modifier = Modifier].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
errorLine1="private fun SettingsSections(modifier: Modifier = Modifier, securityLevel: AccountSecurityLevel) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/com/infomaniak/auth/ui/screen/AccountDetails.kt"
line="234"
column="29"/>
</issue>

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [title: String, modifier: Modifier = Modifier, style: ButtonStyle = ButtonStyle.Primary, enabled: () -> Boolean = { true }, showIndeterminateProgress: () -> Boolean = { false }, progress: (() -> Float)? = null, onClick: () -> Unit, imageVector: ImageVector? = null] but should be [title: String, onClick: () -> Unit, modifier: Modifier = Modifier, style: ButtonStyle = ButtonStyle.Primary, enabled: () -> Boolean = { true }, showIndeterminateProgress: () -> Boolean = { false }, progress: (() -> Float)? = null, imageVector: ImageVector? = null].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
Expand All @@ -56,15 +34,4 @@
column="16"/>
</issue>

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [modifier: Modifier = Modifier, sections: ImmutableList&lt;ImmutableList&lt;OptionItemType>>, content: @Composable (optionItem: List&lt;OptionItemType>) -> Unit] but should be [sections: ImmutableList&lt;ImmutableList&lt;OptionItemType>>, modifier: Modifier = Modifier, content: @Composable (optionItem: List&lt;OptionItemType>) -> Unit].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
errorLine1="private fun OptionsSectionContainer("
errorLine2=" ^">
<location
file="src/main/kotlin/com/infomaniak/auth/ui/components/OptionsSection.kt"
line="76"
column="36"/>
</issue>

</issues>
Loading