Skip to content

feat(ascend): add rotary_embedding operator#786

Draft
zhangyue207 wants to merge 1 commit into
InfiniTensor:masterfrom
zhangyue207:feat/ascend-rotary-embedding-operator
Draft

feat(ascend): add rotary_embedding operator#786
zhangyue207 wants to merge 1 commit into
InfiniTensor:masterfrom
zhangyue207:feat/ascend-rotary-embedding-operator

Conversation

@zhangyue207

Copy link
Copy Markdown
Collaborator

Summary

  • Add the Ascend rotary_embedding implementation adapted to the existing upstream master base API.
  • Keep the upstream base signature and do not include the origin-only optional key, inplace, pre_gathered, 2D, ATB, or partial-rotary API extensions.
  • Add focused tests/test_rotary_embedding.py coverage for the supported 3D full-rotary path.

Validation

  • git diff --check upstream/master...HEAD
  • clang-format --dry-run --Werror src/native/ascend/ops/rotary_embedding/kernel.h
  • ruff format --check tests/test_rotary_embedding.py
  • ruff check tests/test_rotary_embedding.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant