feat: expose returning add python call#774
Open
voltjia wants to merge 3 commits into
Open
Conversation
d424f0e to
3fcad40
Compare
3fcad40 to
330468c
Compare
330468c to
766e3d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MakeReturnValue, enabled only foraddin this PR.Pybind11Tensorhelpers for constructing returned PyTorch tensors through the external tensor protocol.tests/test_add.py::test_addcoverage: contiguous output cases call the returning overload, while existing in-place cases remain covered.Motivation
Returning-style Python calls are more ergonomic for Python users, but InfiniOps still should not own tensor storage. This PR exposes that behavior through the existing external tensor construction protocol and keeps the rollout narrow to
add.Closes N/A - no linked issue.
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
tests/test_generate_wrappers.py tests/test_add.py --devices nvidia: 191 passed, 36 skippedAdditional checks
Benchmark / Performance Impact
N/A - API binding change only.
Notes for Reviewers
matmulreturning Python exposure is intentionally out of scope for this PR._PY_RETURNING_OPS; currently onlyaddis enabled.matmulsmoke-build warning is expected on NVIDIA because this PR does not add a NVIDIA or PyTorch fallback implementation formatmul.