feat(ascend): add scaled softmax operator#599
Draft
zhangyue207 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScaledSoftmaxbase operator for 2D logits/probability normalization.aclnnMulsfollowed byaclnnSoftmax.Motivation
ScaledSoftmaxis needed as a small inference operator for logits-style normalization on Ascend.Closes N/A
API Alignment
torch.nn.functional.softmax(input, dim=None, _stacklevel=3, dtype=None).scaled_softmax(input, scale, out).scaleis explicit because this operator modelssoftmax(input * scale, dim=-1)and uses InfiniOps output-explicit calling style.tests/test_scaled_softmax.pycompares againsttorch.nn.functional.softmax(input.to(torch.float32) * scale, dim=-1).Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResultinfiniops-pr-ascend-0512,ASCEND_VISIBLE_DEVICES=0.Full `pytest` output
Benchmark / Performance Impact
N/A
Notes for Reviewers
float16,bfloat16, andfloat32tensors.Checklist
Title, Branch, and Commits
<type>/xxx-yyyy-zzzz.master.fixup!/squash!/wipcommits remain.Scope and Design
TODOentries.General Code Hygiene
git diff --checkpasses.C++ Specific
clang-format --dry-run --Werror src/base/scaled_softmax.h src/native/ascend/ops/scaled_softmax/kernel.hpasses.kernel.h, matching the local Ascend operator pattern.src/base/<op>.hplussrc/native/ascend/ops/<op>/pattern.new/delete.Python Specific
ruff format --check tests/test_scaled_softmax.pypasses.ruff check tests/test_scaled_softmax.pypasses.Testing
tests/.pytest.mark.parametrizeandpytest.mark.auto_act_and_assert.deviceparameterization is used.Build, CI, and Tooling
pip install .[dev]in the Ascend test container.Documentation
README.md/CONTRIBUTING.mdchanges are not needed for this small operator addition.Security and Safety
AclTensorCachepatterns.