feat: support CCL AllGather - #61
Open
GordonYang1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
AllGathersupport to the shared CCL backend abstraction, including native bindings through the existing NCCL and MCCL provider layers for the publicinfinicclAllGather()API. It also keeps inter-only communicators on the existing OpenMPI staging path during mixed-backend bootstrap flows, corrects the shared OpenMPI/MPICHAllGatherstaging path to use byte counts for all data types, makes the existing MPI example propagate per-block validation failures, and includes CCL-only plus OpenMPI-assistedAllGatherexample programs covering out-of-place and canonical in-place flows.Changes
Public API and Dispatch
infinicclAllGather()API for configured CCL backends through generated bridge dispatch without changing its public signature.AllGatherafter validating the communicator and data type, without requiring non-null buffers or entering a backend.Common CCL Implementation
AllGatherimplementation following the existingAllReducestructure.NotSupportedwhen the provider cannot represent the requested type.Existing CCL Provider Bindings
ncclAllGather()andmcclAllGather().AllGatherwith the existing NCCL and MCCL provider layers.MPI Correctness
AllGatheras a movement operation in the shared OpenMPI/MPICH implementation by usingMPI_BYTEwithcount * type_sizebytes per rank.size_tmultiplication, and MPIintcount-range checks for staged transfers.Examples and Validation
AllGatherexample using one shared unique ID and rank-based communicator initialization.AllGatherexample that first uses the publicAllGatherAPI through the OpenMPI inter communicator to distribute the native unique ID, then initializes the native CCL communicator for GPU data movement.Platform and Backend Affected
Platform
Backend
Performance Impact
This adds GPU-native NCCL and MCCL paths for
AllGather, avoiding the existing MPI host-staging path when a supported CCL backend and native communicator are available. The shared MPI path remains host-staged, with corrected byte-count handling for movement data types. Other collective operations are intended to remain unchanged.Known Issues & Future Work
AllReduceandAllGather; other CCL collective operations remain future work.AllGatherinherits the backend/device combinations and data type support of the existing CCL providers; this PR does not add a new provider or device integration.float32payloads on the default stream. Additional data-type and non-default-stream runtime coverage remain future work.intcount range; chunked transfers remain future work.Test Results
Test Involved Platform
Test Involved Backend
Pure CCL (NCCL) on single-node NVIDIA:
ccl_all_gather.log
ccl_all_reduce.log
CCL + MPI on single-node NVIDIA:
ccl_mpi_hybrid_all_gather.log
ccl_mpi_hybrid_all_reduce.log
MPI on Heterogeneous Cluster:
mpi_all_gather.log
mpi_all_reduce.log
mpi_all_to_all.log
mpi_broadcast.log
mpi_gather.log
mpi_reduce.log
mpi_reduce_scatter.log
mpi_scatter.log
mpi_send_recv.log
Pure CCL (MCCL) on single-node MetaX:
ccl_all_gather.log
ccl_all_reduce.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see `.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety