build: refresh InfiniCCL environment exports#43
Draft
Ziminli wants to merge 2 commits into
Draft
Conversation
- append both `INFINICCL_ROOT` and `InfiniCCL_ROOT` to `~/.bashrc` when the install path is missing - update existing root exports when they point to a different checkout - clarify the post-install source reminder for path updates
- add a helper to update or append `.bashrc` exports - update `INFINICCL_ROOT` and `InfiniCCL_ROOT` based on `.bashrc` contents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
scripts/build.shto export bothINFINICCL_ROOTandInfiniCCL_ROOTin~/.bashrc. The newInfiniCCL_ROOTexport matches CMake's package-root variable convention forfind_package(InfiniCCL), avoiding reliance on the all-uppercaseINFINICCL_ROOTvariable that can trigger CMP0144 developer warnings in downstream CMake projects.Changes
CMake Package-Root Compatibility
InfiniCCL_ROOTexport to~/.bashrcso downstreamfind_package(InfiniCCL)usage has a CMake-compatible package-root variable;INFINICCL_ROOT, which CMake may ignore forfind_package(InfiniCCL)under CMP0144 compatibility behavior.Environment Setup
~/.bashrcexports or append them when missing;.bashrcupdates out of the current-sessionPATHcheck so root variables are maintained even whenPATHalready contains the install bin directory.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A. This PR only changes build/install environment setup in
scripts/build.sh.Known Issues & Future Work
Test Results
Test Involved Platform
Test Involved Backend
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety