Skip to content

refactor: categorize examples/ directory and update scripts/run_examples.py#42

Merged
GordonYang1 merged 4 commits into
masterfrom
refactor/categorize-examples
Jun 29, 2026
Merged

refactor: categorize examples/ directory and update scripts/run_examples.py#42
GordonYang1 merged 4 commits into
masterfrom
refactor/categorize-examples

Conversation

@Ziminli

@Ziminli Ziminli commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR reorganizes internal examples under category directories, starting with the current MPI examples under examples/mpi/. It updates examples/CMakeLists.txt, scripts/run_examples.py, and README.md so examples can be built and run by category or by path (e.g. mpi, mpi/all_reduce).

Changes

  • Example layout

    • Move existing MPI example sources from examples/*.cc to examples/mpi/*.cc;
    • Preserve executable names while placing built binaries under matching category directories.
  • Build integration

    • Generate unique CMake target names such as mpi_all_reduce while keeping runtime output paths like mpi/all_reduce.
  • Example runner

    • Update scripts/run_examples.py to discover examples recursively;
    • Support selecting examples by category, exact path, or short name, such as mpi, mpi/all_reduce, or all_reduce;
    • Default --examples to mpi.
  • Documentation

    • Update README.md with the new examples/ directory layout and icclrun usage.

Platform and Backend Affected

Platform

  • N/A- CPU
  • N/A- NVIDIA GPU
  • N/A- Iluvatar GPU
  • N/A- MetaX GPU
  • N/A- Moore Threads GPU
  • N/A- Cambricon MLU

Backend

  • N/A- OpenMPI
  • N/A- MPICH

Performance Impact

  • No performance impact
  • Performance improved
  • Performance regression possible

N/A.

Known Issues & Future Work

  • Other categories will be added in the future.

Test Results

Test Involved Platform

  • CPU
  • NVIDIA GPU
  • Iluvatar GPU
  • MetaX GPU
  • Moore Threads GPU
  • Cambricon MLU

Test Involved Backend

  • OpenMPI
  • MPICH

NVIDIA + MetaX:

Note: the following examples are run using: ./scripts/run_examples.py -e mpi.

mpi_all_gather.log
mpi_all_reduce.log
mpi_all_to_all.log
mpi_broadcast.log
mpi_gather.log
mpi_reduce.log
mpi_reduce_scatter.log
mpi_scatter.log
mpi_send_recv.log


Checklist

Every contributor must verify every item below before requesting
review. Tick each box only after the check has actually been performed —
do not tick speculatively. If an item truly does not apply, replace the
checkbox with N/A and briefly explain why in an inline comment.

Title, Branch, and Commits

  • PR title follows Conventional Commits (e.g. feat: …, fix(nccl): …).
  • Branch name follows <type>/xxx-yyyy-zzzz where <type> matches the PR title's Conventional Commits type and words are joined with hyphens (see CONTRIBUTING.md §Branches).
  • Each commit message follows Conventional Commits.
  • Small PR is a single squashable commit; or, for a large PR, every commit is meaningful, well-formed, and independently reviewable (see CONTRIBUTING.md §Pull Requests).
  • No stray merge commits from master — the branch is rebased cleanly on top of the current master.
  • No fixup! / squash! / wip commits remain.

Scope and Design

  • Changes are minimal — no unrelated modifications were introduced (CONTRIBUTING.md §Code/General).
  • No dead code, commented-out blocks, debug prints, printf/std::cout/print(...) left behind, or TODO without an owner and issue link.
  • No unrelated formatting churn that would obscure the diff.
  • Public API changes (if any) are intentional, documented, and reflected in affected callers/tests.

General Code Hygiene

  • The code is self-explanatory; comments were added only where the intent or rationale is non-obvious (CONTRIBUTING.md §Code/General).
  • Every modified or added file ends with a single trailing newline (CONTRIBUTING.md §Code/General).
  • No trailing whitespace, inconsistent indentation, or mixed formatting styles remain.
  • Identifiers referenced in comments or error messages are wrapped in Markdown backticks (e.g. the `AllReduce` implementation) (CONTRIBUTING.md §Code/General).
  • All comments and error messages are in English (CONTRIBUTING.md §Code/General).
  • Comments and error messages are complete sentences — capitalized first letter, terminal punctuation — unless the language/framework convention says otherwise (CONTRIBUTING.md §Code/General; §Python).

C++ Specific (if C++ files changed)

  • N/A- Code follows the Google C++ Style Guide strictly.
  • N/A- clang-format (version 16, per .github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.
  • N/A- No exceptions are thrown. Error paths use assert with messages that include at least __FILE__, __LINE__, and __func__ (CONTRIBUTING.md §C++).
  • N/A- Error and warning message wording follows the LLVM Coding Standards (CONTRIBUTING.md §C++).
  • N/A- Constructor initializer list order matches member declaration order (CONTRIBUTING.md §C++).
  • N/A- Exactly one blank line between classes, between classes and functions, and between functions (CONTRIBUTING.md §C++).
  • N/A- Exactly one blank line between members (functions and variables) within a class (CONTRIBUTING.md §C++).
  • N/A- Exactly one blank line before and after the contents of a namespace (CONTRIBUTING.md §C++).

Python Specific (if Python files changed)

  • Code is PEP 8 compliant; ruff check passes cleanly on CI (see .github/workflows/ruff.yml).
  • ruff format --check passes cleanly — if not, run ruff format and commit the result.
  • Comments are complete English sentences, starting with a capital letter and ending with punctuation; Markdown backticks are used for code references (CONTRIBUTING.md §Python).
  • Framework-specific conventions (e.g. lowercase pytest.skip messages without terminal period) are honored where applicable (CONTRIBUTING.md §Python).
  • No blank line between the function signature and the body when there is no docstring or comment (CONTRIBUTING.md §Python).
  • A blank line is present before and after if, for, and similar control-flow statements (CONTRIBUTING.md §Python).
  • A blank line appears before each return, except when it directly follows a control-flow statement (CONTRIBUTING.md §Python).
  • Docstrings (if any) follow PEP 257 (CONTRIBUTING.md §Python).
  • Type hints are added / kept consistent with the surrounding code.

Testing

  • All applicable example programs have been built and tested successfully on at least one supported heterogeneous cluster setup.

Build, CI, and Tooling

  • N/A- New backends or devices have been added to auto-detection in CMakeLists.txt under if(AUTO_DETECT_DEVICES) or to if(AUTO_DETECT_BACKENDS) if applicable.
  • Both CI workflows (clang-format.yml, ruff.yml) are green locally (or expected to be green on CI).

Documentation

  • README.md, CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.
  • Any user-visible breaking change is called out explicitly under "Summary" and in the commit/PR title with a ! or BREAKING CHANGE: footer.

Security and Safety

  • No secrets, access tokens, internal URLs, customer data, or personal hardware identifiers have been committed.
  • N/A- Third-party code is license-compatible and attributed.
  • No unsafe pointer arithmetic, uninitialized reads, or missing bounds checks were introduced.

@Ziminli Ziminli self-assigned this Jun 29, 2026
@Ziminli Ziminli requested a review from GordonYang1 June 29, 2026 09:31
Ziminli added 4 commits June 29, 2026 10:09
… different types of examples and update `scripts/run_examples.py`

 - restructure the `examples/` to categorize different types of examples
 - update `scripts/run_examples.py` to accommodate this change and be able to specify an example directory, specific examples, or fuzzy example names
@Ziminli Ziminli force-pushed the refactor/categorize-examples branch from 8c24bc2 to 67dc13c Compare June 29, 2026 10:18
@GordonYang1 GordonYang1 merged commit bb58c94 into master Jun 29, 2026
2 checks passed
@Ziminli Ziminli deleted the refactor/categorize-examples branch June 30, 2026 02:38
Ziminli added a commit that referenced this pull request Jun 30, 2026
…amples.py` (#42)

* docs: remove the `examples/` structure diagram

* docs: update `README.md` to reflect the new file structure of `examples/`

* style: ruff format `scripts/run_examples.py`

* refactor: change the directory structure of `examples/` to categorize different types of examples and update `scripts/run_examples.py`
    - restructure the `examples/` to categorize different types of examples
    - update `scripts/run_examples.py` to accommodate this change and be able to specify an example directory, specific examples, or fuzzy example names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants