Skip to content

fix(paper): unsafe registration under existing roots #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpenilla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(paper): unsafe registration under existing roots #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions cloud-paper/src/main/java/org/incendo/cloud/paper/ModernPaperBrigadier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,19 +205,11 @@ public boolean registerCommand(final @NonNull Command<C> command) {
}

if (this.aliases.containsKey(command.rootComponent().name())) {
final CommandDispatcher<CommandSourceStack> dispatcher =
unsafeGet(commands, Commands::getDispatcher);
final RootCommandNode<CommandSourceStack> root = unsafeGet(commands, cmds -> cmds.getDispatcher().getRoot());
final Set<String> registered = this.aliases.get(command.rootComponent().name());
final LiteralCommandNode<CommandSourceStack> newRoot = this.createRootNode(
this.manager.commandTree().getNamedNode(command.rootComponent().name()),
command.rootComponent().name()
);
final CommandNode<C> rootNode = this.manager.commandTree().getNamedNode(command.rootComponent().name());
for (final String label : registered) {
final com.mojang.brigadier.tree.CommandNode<CommandSourceStack> node =
dispatcher.getRoot().getChild(label);
for (final com.mojang.brigadier.tree.CommandNode<CommandSourceStack> newChild : newRoot.getChildren()) {
node.addChild(newChild);
}
root.addChild(this.createRootNode(rootNode, label));
}
} else {
unsafeOperation(commands, cmds -> this.registerCommand(
Expand Down