Skip to content

fix(vm): range-check magnitude before the long long cast in value_to_string (#695) #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InauguralPhysicist merged 1 commit into from
Jul 24, 2026
Merged

fix(vm): range-check magnitude before the long long cast in value_to_string (#695) #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/eigenscript.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ char* value_to_string(Value *v) {
double n = v->data.num;
/* Exact integers up to 2^53 (the largest integer all doubles
* represent exactly) print without a decimal point or exponent. */
if (n == (long long)n && fabs(n) < 9007199254740992.0) {
if (fabs(n) < 9007199254740992.0 && n == (long long)n) {
snprintf(buf, sizeof(buf), "%lld", (long long)n);
} else {
/* Shortest representation that round-trips: try 15..17
Expand Down
Loading