Fix deterministic build#28
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts MSBuild/NuGet configuration to make builds more deterministic by removing conditional package inclusion logic and dropping an implicit global SourceLink dependency.
Changes:
- Remove the conditional
ItemGroupgatingMicrosoft.Extensions.DependencyInjection.Abstractionsso it is referenced consistently across target frameworks. - Remove the global
Microsoft.SourceLink.GitHubpackage reference from central package management.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Immediate.Injections.Shared/Immediate.Injections.Shared.csproj | Makes the DI abstractions package reference unconditional to avoid conditional restore/build variability across TFMs. |
| Directory.Packages.props | Removes the global SourceLink GitHub package reference to reduce deterministic-build variability caused by global package injection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.