Update FQMN for NRT#27
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the source generator’s fully-qualified type-name formatting to preserve nullable reference type (NRT) annotations when rendering service/implementation types in generated DI registrations.
Changes:
- Introduce
DisplayNameFormatters.FullyQualifiedWithNullableFormat(FullyQualified +IncludeNullableReferenceTypeModifier). - Switch registration/type rendering in
ImmediateInjectionsGenerator.Transformto use the new formatter for service types and implementation type arguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Immediate.Injections.Generators/ImmediateInjectionsGenerator.Transform.cs |
Uses the new nullable-aware fully-qualified formatting when storing service/implementation type strings for rendering. |
src/Immediate.Injections.Generators/DisplayNameFormatters.cs |
Adds a new SymbolDisplayFormat intended to include nullable reference modifiers in fully-qualified type names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.