Skip to content

fix(ci): run DMV build in node_modules directory #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoroctaviano merged 1 commit into from
Aug 14, 2026
Merged

fix(ci): run DMV build in node_modules directory #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-to-firebase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
# Build DMV if dist files are missing (git dependency in package.json)
if [ ! -f "node_modules/dicom-microscopy-viewer/dist/dynamic-import/dicomMicroscopyViewer.min.js" ]; then
echo "DMV dist files missing - building from git dependency"
pnpm --filter dicom-microscopy-viewer run build
(cd node_modules/dicom-microscopy-viewer && pnpm run build)
fi

- name: Require preview DICOMweb URL
Expand Down