Skip to content

Configure Slim logger at startup and fix icon type issues#395

Merged
igoroctaviano merged 1 commit into
masterfrom
fix/slim-logger-and-icon-types
Jul 6, 2026
Merged

Configure Slim logger at startup and fix icon type issues#395
igoroctaviano merged 1 commit into
masterfrom
fix/slim-logger-and-icon-types

Conversation

@igoroctaviano

Copy link
Copy Markdown
Collaborator

Summary

  • Configure Slim's logger from window.config.logger at application startup via logger.configure() in index.tsx
  • Simplify Button icon prop typing to accept IconType and generic React components
  • Add types/react-antd-icons.d.ts to augment React DOMAttributes with optional pointer-capture handlers required by @ant-design/icons@4 under @types/react ts5.0

Notes

  • Branch is based on master, not feat/viv-loader
  • Includes only the previously staged changes (logger startup config, Button typing, react-antd-icons types)
  • The types/dicom-microscopy-viewer/index.d.ts hunk from the staged diff was omitted because master does not define setLogLevel there

Test plan

  • pnpm run typecheck passes
  • pnpm start loads with REACT_APP_CONFIG=example and respects config.logger settings
  • Ant Design icon buttons render without TypeScript errors

Apply window.config.logger through Slim's logger at boot, simplify Button icon prop typing, and add React DOMAttributes augmentation for @ant-design/icons pointer-capture handlers.
@deepsource-io

deepsource-io Bot commented Jul 6, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 41b3690...f51bbc8 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jul 6, 2026 5:14p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit f51bbc8):

https://idc-external-006--pr395-fix-slim-logger-and-bjthz516.web.app

(expires Mon, 13 Jul 2026 17:16:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

@igoroctaviano igoroctaviano merged commit d177097 into master Jul 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant