Skip to content

fix(378/327/377/353): DICOM tag browser, worklist (including Modalities in Study when QIDO omits it), overlay colormaps, header badge behavior, and test/tooling updates #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoroctaviano merged 8 commits into from
Apr 14, 2026

Add species and admitting parsing

b99e812
Select commit
Loading
Failed to load commit list.
Merged

fix(378/327/377/353): DICOM tag browser, worklist (including Modalities in Study when QIDO omits it), overlay colormaps, header badge behavior, and test/tooling updates #379

Add species and admitting parsing
b99e812
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 26, 2026 in 38s

Quality Gate failed

Failed conditions
5 Security Hotspots
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 25 in src/utils/logger.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis.window` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0fuTDDNpE5n0zJUKms&open=AZ0fuTDDNpE5n0zJUKms&pullRequest=379

Check warning on line 25 in src/utils/logger.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0fuTDDNpE5n0zJUKmr&open=AZ0fuTDDNpE5n0zJUKmr&pullRequest=379

Check warning on line 25 in src/utils/logger.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0fuTDDNpE5n0zJUKmt&open=AZ0fuTDDNpE5n0zJUKmt&pullRequest=379

Check warning on line 38 in src/components/Patient.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0rW3LLTiLYW-eKgX6x&open=AZ0rW3LLTiLYW-eKgX6x&pullRequest=379

Check failure on line 93 in src/utils/values.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0rZZL10GVV5QbRj7xl&open=AZ0rZZL10GVV5QbRj7xl&pullRequest=379

Check failure on line 202 in src/components/Worklist.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide a compare function that depends on "String.localeCompare", to reliably sort elements alphabetically. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0fuTIgNpE5n0zJUKmw&open=AZ0fuTIgNpE5n0zJUKmw&pullRequest=379

Check warning on line 51 in src/components/Patient.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0rZZPi0GVV5QbRj7xm&open=AZ0rZZPi0GVV5QbRj7xm&pullRequest=379

Check warning on line 278 in src/components/DicomTagBrowser/dicomTagUtils.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0c0cMXLvrw8DEQKLgC&open=AZ0c0cMXLvrw8DEQKLgC&pullRequest=379

Check warning on line 91 in src/components/Worklist.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use callback in setState when referencing the previous state. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0fuTIgNpE5n0zJUKmv&open=AZ0fuTIgNpE5n0zJUKmv&pullRequest=379

Check warning on line 34 in src/components/Worklist.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The empty check is useless as `Array#every()` returns `true` for an empty array. 

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AZ0fuTIgNpE5n0zJUKmu&open=AZ0fuTIgNpE5n0zJUKmu&pullRequest=379
View more details on SonarQubeCloud