Skip to content

Update node version in github actions#12

Merged
fedorov merged 6 commits intoImagingDataCommons:masterfrom
rflamand:feature/rflamand/bump_node_version_to_lts_v24
Feb 28, 2026
Merged

Update node version in github actions#12
fedorov merged 6 commits intoImagingDataCommons:masterfrom
rflamand:feature/rflamand/bump_node_version_to_lts_v24

Conversation

@rflamand
Copy link
Contributor

@rflamand rflamand commented Feb 20, 2026

I have updated the node version in the github action scripts to the latest active LTS version (24.13.1). This comes with a newer npm version, which allows us to use the open id infrastructure when publishing to npm.

While doing this, I've also

  1. Fixed the npm package url (we had to add git+ in front)
  2. Bumped the package to version 0.2.4 (dry run whines about this and apperently, 0.2.3 is already published)

@rflamand
Copy link
Contributor Author

rflamand commented Feb 20, 2026

The job seems to fail on the npm dry run. Im not 100% sure on the specifics of the dry run, ill try to take a look next week!

@rflamand
Copy link
Contributor Author

Apparently, dry run also checks the version (so it does everything except the actual publishing, which makes sense). 0.2.2 is already published in this case, so it fails. Consequently, we'll need to ensure that the first PR/commit after every release is the version bump (though we'll immediately see it as the checks will fail).

We could also remove the dry run check from normal checks. Doing so would allow us to choose the next version number right before the release (and not right after the previous one). It's whatever you feel most comfortable with @fedorov.

@fedorov
Copy link
Member

fedorov commented Feb 23, 2026

We could also remove the dry run check from normal checks. Doing so would allow us to choose the next version number right before the release (and not right after the previous one).

I am not sure I understand! But I think it's ok to remove dry run.

Let me know when this PR is ready and I will merge!

@rflamand
Copy link
Contributor Author

We could also remove the dry run check from normal checks. Doing so would allow us to choose the next version number right before the release (and not right after the previous one).

I am not sure I understand! But I think it's ok to remove dry run.

Let me know when this PR is ready and I will merge!

Alright I'll remove the dry run.

The main benefit from this is that we can choose when we update the version in package.json. This means that we can update the version number based on the changes (e.g. major version increment for breaking changes, minor for little changes, ...). If we did not remove the dry-run, then we would need to update the version number in package.json every time right after release. If we would not update it, then the jobs would fail similarly to this one. (However, this is not a problem as we're removing the dry run).

@rflamand
Copy link
Contributor Author

@fedorov I've pushed the patch, dry run has now been removed. I've also restored the version as the version bump is no longer needed for the job to complete.

@fedorov
Copy link
Member

fedorov commented Feb 27, 2026

I've also restored the version as the version bump is no longer needed for the job to complete.

Sorry for the delay replying. I have to admit I don't understand this part. I thought that the version in package.json should always be updated prior to publishing a new release? My understanding is the steps are: 1) update version in json and push/merge; 2) once the new version is in master, create a new GitHub release to trigger the npmjs upload. Am I missing something?

@rflamand
Copy link
Contributor Author

No, you're completely right in how you present the release flow.

I bumped the version to 0.2.4 (that is in package.json) in this PR as to avoid the issue we saw in the jobs. The root cause for the issue was that the dry run already compared to the current version on npm and it failed because the current version (0.2.3) is already published.

However, now that I've removed the dry run step, this job will nog longer fail. Consequently, the version no longer has to be bumped to 0.2.4 for the job to pass. Because of this, I have removed the version bump. Later, if we want to release a new version, we can bump the version to 0.2.4 (or any other) before releasing.

Sorry that it was not clear earlier. I hope this explanation helps somewhat.

@fedorov
Copy link
Member

fedorov commented Feb 28, 2026

It does, thank you!

@fedorov fedorov merged commit cbc4d98 into ImagingDataCommons:master Feb 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants