Close file pointer in finally clause#125
Open
erikogabrielsson wants to merge 1 commit into
Open
Conversation
|
pieper
requested changes
Jul 11, 2026
pieper
left a comment
pieper
left a comment
Member
There was a problem hiding this comment.
this sounds like a good fix. Can you look at the automated suggestions?
Contributor
Author
|
@pieper: Do you mean the suggestions from |
Member
|
Okay, if the issues are unrelated then you don't need to resolve them. I haven't worked on this code for a while so I'm hesitant to make changes. Is there anyone else who uses this package actively who would like to review? |
Collaborator
|
@pieper I will take a look in the next couple of days |
CPBridge
approved these changes
Jul 16, 2026
CPBridge
left a comment
CPBridge
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks @erikogabrielsson !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions in
DICOMfileClientretrieve_instance_rendered(),iter_instance_frames(),retrieve_instance_frames(), andretrieve_instance_frames_rendered()or if caller abandons iteration early oniter_instance_frames()leaves theimage_file_pointeropen. Change so that it is always closed in afinallyblock.