fix: scope GCP packages to prevent dependency confusion (BRISKET-W103)#130
Merged
Merged
Conversation
Rename ohif-gcp-mode and ohif-gcp-extension dependencies to the @idc scoped packages, pin them to explicit Git commit SHAs, and document the registry policy in .npmrc to mitigate supply-chain substitution risk.
Update @idc/gcp-mode and @idc/gcp-extension to the current main branch HEAD on their respective repositories.
Member
|
this has passed the retest by Synack: 
Please move to production. Thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ohif-gcp-modeandohif-gcp-extensionto scoped@idc/gcp-modeand@idc/gcp-extensionto prevent public npm registry substitution (Synack BRISKET-W103).#main..npmrcdocumenting that@idcpackages must be installed from Git URLs only.Related changes
Requires the following commits on the GCP package repos (already on
main):Test plan
yarn install --frozen-lockfilesucceedsyarn buildcompletes without module resolution errors